FEAT: added ability to toggle between selected languages

FossifyOrg / Keyboard

Easy keyboard for inserting all kinds of texts, special characters and numbers.

https://www.fossify.org

GNU General Public License v3.0

285 stars 25 forks source link

FEAT: added ability to toggle between selected languages #40

Closed ronniedroid closed 6 months ago

ronniedroid commented 6 months ago

What is it?

[ ] Bugfix
[x] Feature
[ ] Codebase improvement

Description of the changes in your PR

Added a toggle languages button between the emoji key and the space bar (In all languages layouts)
Removed the comma key (as we can reach the comma by long pressing the period key)
Moved the select language secondary key (popup) to the newly added toggle languages key
Made sure the icon of the key is visible in light and dark themes (by applying appropriate colors)
Implemented the functionality to toggle between the languages

Before/After Screenshots/Screen Record

After:

Acknowledgement

[x] I read the contribution guidelines.

ronniedroid commented 6 months ago

@naveensingh sorry I did not wait for the discussion to be resolved, I had some time to spare today and decided to put this here in case you would like to merge it before the first release. I added the toggle key at the bottom row, in case you want it in the toolbar instead of at the bottom row, let me know and I will move it there. best regards.

Aga-C commented 6 months ago

I think comma is a popular character, and we can't just remove its separate button. I haven't seen the keyboard without a comma button. Maybe you should do it similarly as it is in Gboard - emojis are moved to the comma long-press, so there's a place for language change button between comma and space bar.

ronniedroid commented 6 months ago

I think comma is a popular character, and we can't just remove its separate button. I haven't seen the keyboard without a comma button. Maybe you should do it similarly as it is in Gboard - emojis are moved to the comma long-press, so there's a place for language change button between comma and space bar.

The AOSP keyboard doesn't have a dedicated comma key, but your idea also sounds good, should I do that?

Aga-C commented 6 months ago

I don't know, you may try if you like. If I were you, I'd wait a bit, maybe Naveen will give his opinion soon.

ronniedroid commented 6 months ago

I just noticed that I have put the button to the left of the emoji key and not the right 😅, will fix later.

naveensingh commented 6 months ago

Closing because https://github.com/FossifyOrg/Keyboard/discussions/25#discussioncomment-9561990