search

FossifyOrg / Launcher

A practical and customizable launcher for launching your favorite apps easily.
https://www.fossify.org
GNU General Public License v3.0
78 stars 7 forks source link

Add simple GitHub action for static checks and tests #12

Closed esensar closed 5 months ago

esensar commented 5 months ago

Enabled android lint, added detekt and created github workflow for PRs. Related to discussion: https://github.com/orgs/FossifyOrg/discussions/83

naveensingh commented 5 months ago

@esensar this looks ready to be merged. Is it ready to be merged?

naveensingh commented 5 months ago

All checks have passed :rocket:

esensar commented 5 months ago

I responded in https://github.com/orgs/FossifyOrg/discussions/83, but for visibility, I will also reapond here. I thought we could iron the workflow out here (as much as we can at this stage, there will probably be changes in the future) and then just copy it over to other repos when done.

esensar commented 5 months ago

I think this is done for now. App is built and uploaded as actions artifact. That download link is maybe not very visible, so it may be good to add another job to post a comment on PR once APK is uploaded.

Other than that, we could consider not building APKs for all changes and all PRs, but maybe we can refine that later on.

naveensingh commented 5 months ago

@esensar please revert 4aadef54c7a16914524a279f824076ab55d4669d (https://github.com/orgs/FossifyOrg/discussions/83#discussioncomment-8260802)

naveensingh commented 5 months ago

Thank you :)