search

FossifyOrg / Messages

An easy and quick way of managing SMS and MMS messages without ads.
https://www.fossify.org
GNU General Public License v3.0
419 stars 30 forks source link

Draft saved despite being erased #13

Open Cwpute opened 6 months ago

Cwpute commented 6 months ago

Checklist

Describe the bug I have one conversation in which the previous draft keeps being saved. Let's say the draft read hello, i enter the conversation, erase the text in the text area, leave the conversation… the draft still

To Reproduce Steps to reproduce the behavior:

  1. Enter a conversation page
  2. Write some text in the text area: eg. hello
  3. Leave the conversation
  4. Draft is saved as expected, shown to be hello
  5. Enter the conversation again
  6. Change draft to any other text, a single letter is enough: eg E
  7. Leave conversation
  8. Draft is changed and saved as expected, and is shown to be E
  9. Enter conversation again
  10. Erase entirely previous draft E from the text area
  11. Leave conversation
  12. Draft isn't erased and is shown to still be E

Expected behavior Draft should be erased and forgotten about after being deleted from the text area

Device info (please complete the following information):

Additional context i checked on SMT issue tracker and haven't seen issues about this.

Aga-C commented 6 months ago

I've checked it on three different phones, with different Android versions, and I couldn't reproduce it, so I set this bug as device specific.

If someone else also encountered this issue, please let us know what device and OS are you using.

Cwpute commented 6 months ago

Yeah it seems strange here too because the bug seemingly happened out of nowhere, i had drafts before on the same app version but this has never happened.

I suspected this had something to do with the specific conversation it happened in first, but i don't know why. The main difference from other conversations i can think of is that i sent a lot of MMS in the past and still do. But i tried with several other conversations after that and i can reproduce it 🤔

Maybe something to do with my keyboard ? i use AnysoftKeyboard, and have also installed ThumbKey, which i don't use. I'll have a look into it.

Le 28 décembre 2023 12:21:52 GMT+01:00, Agnieszka C @.***> a écrit :

I've checked it on three different phones, with different Android versions, and I couldn't reproduce it, so I set this bug as device specific.

If someone else also encountered this issue, please let us know what device and OS are you using.

-- Reply to this email directly or view it on GitHub: https://github.com/FossifyOrg/SMS-Messenger/issues/13#issuecomment-1871073284 You are receiving this because you authored the thread.

Message ID: @.***>

Chaman-veteran commented 5 months ago

If someone else also encountered this issue, please let us know what device and OS are you using.

I have the same issue on Pixel 6A Android 14 (using SMT 5.19.3) but it seems pretty random. So far it only happened for 2 discussions for me, and uninstall/clear cache doesn't remove the draft.

Maybe something to do with my keyboard ?

I'm using FlorisBoard keyboard so it doesn't seems to be linked to the keyboard we use...

PrivacyFriendlyMuffins commented 5 months ago

Same thing is happening to me, but only on 1 contact.

Device: Motorola One 5g Ace OS: Android 11

I use OpenBoard.

PrivacyFriendlyMuffins commented 5 months ago

So, I know this is open-source, so I'm trying my best to be patient, but I just thought I'd ask if there is any progress on fixing this. :)

DeclanChidlow commented 4 months ago

I would like to add that I encounter this bug as well. I'm using a Nokia G22 with Android 13. I downloaded Fossify from F-Droid using NeoStore my keyboard of choice is FlorisBoard.

No other apps exhibit this behavior. Let me know if there is any further information I can provide.

anaskaejdar commented 4 months ago

What if there was a “clear all drafts” button somewhere? Even if this wasn't a problem, it would be good to have that.

And then, imagine!: In the long term, that feature could expand into a separate page or tab which would list all saved drafts, just like a traditional email client, where you could select, deselect, and delete them. And there could be another tab-or-page which would list scheduled messages that haven't been sent yet.

All that is to say that even though for the problem at hand, it's mere bandagework, this would be a good move, which would even pave the way for some nice extra UX improvements later. And it would be very effective bandagework.

anaskaejdar commented 4 months ago

by the way, I noticed that it's more likely to create a problem if you write a message, switch focus to a different app, and then come back. Switching focus causes a draft to be saved. But it seems like the draft can never be overwritten by an empty string, so if you erase everything and try the same routine, the old message comes back.

Cwpute commented 4 months ago

Agreed. An option to "clear all drafts" would at least alleviate the issue and provide us with some way to circumvent the problem until it is solved.

Le 24 février 2024 21:01:55 GMT+01:00, "Anastázius Kaejatídarján" @.***> a écrit :

What if there was a “clear all drafts” button somewhere? Even if this wasn't a problem, it would be good to have that.

And then, imagine!: In the long term, that feature could expand into a separate page or tab which would list all saved drafts, just like a traditional email client. And there could be another tab-or-page which would list scheduled messages that haven't been sent yet.

All that is to say that even though for the problem at hand, it's mere bandagework, this would be a good move, which would even pave the way for some nice extra UX improvements later. And it would be vely effective bandagework.

-- Reply to this email directly or view it on GitHub: https://github.com/FossifyOrg/Messages/issues/13#issuecomment-1962676191 You are receiving this because you authored the thread.

Message ID: @.***>

TesterEU commented 3 months ago

This basic functionality hasn't been fixed yet?! People are reporting this error on the internet (App ratings are getting lower):

  1. https://liliputing.com/fossify-apps-pick-up-where-simple-mobile-tools-left-off-free-and-open-source-suite-of-android-apps/
  2. https://play.google.com/store/apps/details?id=org.fossify.messages I've the same problem LG V30 Android version 9 kernel 4.4 (system default keyboard). Will this error be taken seriously?
DeclanChidlow commented 3 months ago

This basic functionality hasn't been fixed yet?! People are reporting this error on the internet (App ratings are getting lower):

1. https://liliputing.com/fossify-apps-pick-up-where-simple-mobile-tools-left-off-free-and-open-source-suite-of-android-apps/

2. https://play.google.com/store/apps/details?id=org.fossify.messages
   I've the same problem LG V30 Android version 9 kernel 4.4 (system default keyboard).
   Will this error be taken seriously?

Tone down the passive aggressive tone. This is a FOSS project being undertaken by volunteers. Hostility leads nowhere.

TesterEU commented 3 months ago

Tone down the passive aggressive tone. This is a FOSS project being undertaken by volunteers. Hostility leads nowhere.

Absolutely not. My tone isn't aggressive. I was alerted to the seriousness of the problem. I'm sorry if I offended anyone. I appreciate the work of volunteers and the fact that open code makes the world better and safer. This makes everyone we know a tester of this application. If the basic functionality doesn't work, people think badly about open source. The problem here is the basic functionality (editing messages) -> draft. Many organizations would choose not to release an application with such a bug or would treat the bug as a top priority.

Back to the topic. Is anyone working on fixing this bug?

DeclanChidlow commented 3 months ago

Cheers for the response. Apologies if I was a tad snappy.

It seems it's on their radar as evidenced by the help wanted tag, but not yet in progress. Likely due to troubles reproducing it.

I encounter it on one of my devices so I may see what I can do when I have time. Saying that, it may be a bit off given my current schedule.

Aga-C commented 3 months ago

@TesterEU We are aware of that issue, that's why it's ready for development (no needs triage label), and we've even labeled it as help wanted to show potential contributors that we'd like help here. There's a lot of work with releasing and maintaining all the apps and none of us do it full-time, please be patient.

RobyB89 commented 3 months ago

Cheers for the response. Apologies if I was a tad snappy.

It seems it's on their radar as evidenced by the help wanted tag, but not yet in progress. Likely due to troubles reproducing it.

I encounter it on one of my devices so I may see what I can do when I have time. Saying that, it may be a bit off given my current schedule.

Thank you for your commitment to solving the problem. I believe that it is worth being an active user -> reporting, paying attention. A passive user will not help in the development of opensource applications.

I'm joining the discussion because I have the same problem with Asus phone.

TesterEU commented 3 months ago

Cheers for the response. Apologies if I was a tad snappy.

no problem. I'm glad I was understood.

@RobyB89 I've the same opinion

@Aga-C I understand and hope the error will be fixed soon. I believe the bug reported is serious. Thank you and everyone involved.

jahway603 commented 3 months ago

I'm using version 1.0.1 (which was released after this Issue was opened) on Android 14 & I am encountering a similar issue with the exception of Step 12 in the OP - after I delete E, there is no draft saved but that message pops up to the top of all the messages, as if it were sent on April 10th, 2024, but it last had conversation within it during January 2024, so I would expect it to return back in the order it was before attemping a drafted message.

Pi-iP commented 2 months ago

Hey there, For information, I am facing the described bug too, with this configuration:

Hoping this problem will finally be solved,

Big thank to all of the team of volunteers working for the community ;) !

ZicPL commented 1 month ago

I read this thread because I had a similar problem. As I see, problem is not solved to this day. All the commenters above didn't want to blame You (and devs). I also don't want to be rude and I want to write that I really appreciate Your work. I'm grateful for Your hard work and participation in FOSS. I've been using a similar application since yesterday: octoshrimpy/quik I'm testing the new app from the link above and so far I haven't had a problem with erased Draft saved messages. Maybe the application code from the link will help you solve the problem reported here. If my message is helpful, please let me know here :)

botus99 commented 1 month ago

Tossing my name in the hat here, hi all. I have been experiencing this error for a while now. Here is my current info...

Hope this info helps someone and thanks for the hard work!

tylerpalcic commented 1 month ago

I've also been seeing this issue for a few months now.