FossifyOrg / Messages

An easy and quick way of managing SMS and MMS messages without ads.
https://www.fossify.org
GNU General Public License v3.0
419 stars 30 forks source link

Added custom notifications #9

Closed Aga-C closed 5 months ago

Aga-C commented 6 months ago

I've moved code from my old pull request from SMT adding custom notifications to the app.

Short summary of changes:

It addresses all requests from original Simple SMS Messenger related to changing sound, silence conversations, overriding do-not-disturb etc., because all of these settings are available in system settings for notification channel. They can differ between various distributions of Android, but what's here can be the basis for further enhancements in case some devices don't support specific options.

https://github.com/FossifyOrg/SMS-Messenger/assets/85929121/f7d25bf4-9a8c-4c91-bafe-58ab3cbc50d1

naveensingh commented 6 months ago

@Aga-C I'll check this later.

Maybe it should "Enable custom notifications" in place of "Use custom notifications"?

naveensingh commented 6 months ago

@Aga-C

There is no ripple when I click on either of the options. Please use the same style as in preferences. Check activity_settings.xml for reference.

That is, use style="@style/SettingsHolderCheckboxStyle" and style="@style/SettingsHolderTextViewOneLinerStyle" and remove the paddings/margins.

naveensingh commented 6 months ago

Actually, the other options there (headings, conversation name, members) won't be aligned properly after applying the preference style so if you want, you can fix them as well using the appropriate style.

Aga-C commented 6 months ago

I've changed it, but I encountered two problems:

naveensingh commented 6 months ago

@Aga-C ok, I'll fix those.

naveensingh commented 5 months ago

Tested it on a couple of devices and it seems to work fine. Thanks :)