Closed Aga-C closed 5 months ago
@Aga-C I'll check this later.
Maybe it should "Enable custom notifications" in place of "Use custom notifications"?
@Aga-C
There is no ripple when I click on either of the options. Please use the same style as in preferences. Check activity_settings.xml
for reference.
That is, use style="@style/SettingsHolderCheckboxStyle"
and style="@style/SettingsHolderTextViewOneLinerStyle"
and remove the paddings/margins.
Actually, the other options there (headings, conversation name, members) won't be aligned properly after applying the preference style so if you want, you can fix them as well using the appropriate style.
I've changed it, but I encountered two problems:
@Aga-C ok, I'll fix those.
Tested it on a couple of devices and it seems to work fine. Thanks :)
I've moved code from my old pull request from SMT adding custom notifications to the app.
Short summary of changes:
It addresses all requests from original Simple SMS Messenger related to changing sound, silence conversations, overriding do-not-disturb etc., because all of these settings are available in system settings for notification channel. They can differ between various distributions of Android, but what's here can be the basis for further enhancements in case some devices don't support specific options.
https://github.com/FossifyOrg/SMS-Messenger/assets/85929121/f7d25bf4-9a8c-4c91-bafe-58ab3cbc50d1