Skip Uses Wrong Button Icon

bigboipete commented 6 months ago

Checklist

[X] I can reproduce the bug with the latest version given here.
[X] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
[X] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
[X] I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected app version

1.0.0

Affected Android/Custom ROM version

ShiftOS 2.0 L (basically AOSP 8.1)

Affected device model

Shift5me

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

This is a rather formal issue (I wouldn't call it a bug):

Open App
Start playing a song
See this screen

Expected behavior

The skip next/back functionality should use the common skip buttons.

Actual behavior

The skip functionality is displayed by the common fast-forward/fast-backward buttons.

Screenshots/Screen recordings

No response

Additional information

Wikipedia: Media Control Symbols

LOUTFI94 commented 6 months ago

Hello, @Bmarwane93 and i we are students at the Paris 8 University (France) and we'd love to be assigned to this task as part of our "free software development" course. It is possible ? Best regard, Loutfi.

naveensingh commented 6 months ago

@LOUTFI94 you are welcome to raise a PR. Please use the material design rounded buttons, click here for an example.

The drawables should be named ic_next_vector.xml and ic_previous_vector.xml and formatted using https://github.com/alexjlockwood/avocado for consistency.

Bmarwane93 commented 6 months ago

Hello here are the changes made, we are beginners in android development, we are doing some research to use avocdo @naveensingh can you maybe open pull request

format icon with avocado:

BEFORE :

<vector xmlns:android="http://schemas.android.com/apk/res/android"
    android:width="24dp"
    android:height="24dp"
    android:viewportWidth="960"
    android:viewportHeight="960">
  <path
      android:pathData="M220,720v-480h80v480h-80ZM740,720L380,480l360,-240v480Z"
      android:fillColor="#5f6368"/>
</vector>

AFTER :

<vector xmlns:android="http://schemas.android.com/apk/res/android" android:width="24dp" android:height="24dp" android:viewportWidth="960" android:viewportHeight="960">
<path android:fillColor="#FF000000" android:pathData="M220 720V240h80v480h-80zm520 0L380 480l360-240v480z"/>
</vector>

a screen shot of the result :

Bmarwane93 commented 6 months ago

@naveensingh this is the link for pull request https://github.com/FossifyOrg/Music-Player/pull/55 work with @LOUTFI94

naveensingh commented 6 months ago

Fixed by https://github.com/FossifyOrg/Music-Player/pull/55

FossifyOrg / Music-Player