Password protect the whole aplication and notes deletion

[WillBBHM]

What is it?

• [ ] Bugfix
• [x] Feature
• [ ] Codebase improvement

This is the link of the feature request : https://github.com/FossifyOrg/Notes/issues/17

Description of the changes and new features

• Added Password protect the whole aplication
• Added Password of the app protect notes deletion
• Added a new settings section to the settings menu, with a checkbox to enable or disable application password protection. (Request user to create a password)

Screenshots

• New Settings "password" added in settings menu:
• App protection at start:
• Notes deletion protection (after confirmation delete):

Acknowledgement

• [x] I read the contribution guidelines.

[Aga-C]

Why haven't you did it similarly as it's done in other apps? Why new strings, new config items?

Check how it's done in Gallery:

• Settings activity ← take a look that no new items in config needs to be made since they are already in BaseConfig from Commons
• Settings.xml ← see that all strings are currently defined in Commons, no need to create new ones
• Main activity ← also using logic from Commons, hiding whole app behind password is just few lines of code

BTW. In template there was Fixes # because GitHub will automatically close original issue after merging if this syntax is used. It makes our work easier, because we don't need to manually close issues then.

[WillBBHM]

The new configuration items and character strings were added because they weren't already there (as they're not a note but the application, I had to modify them slightly). As for the config, it's because the application remembers its passwords, but the application itself isn't a note, and I wanted the application to take the same form as the way notes are protected, to protect the application.

[Aga-C]

I know they weren't defined in Notes, but they are already in Commons, which is imported everywhere, and you can just use it. Look at the Gallery code I sent you, there's also a whole app blocked, and it's fully using things from Commons.

[WillBBHM]

As I'm still a computer science student, could you please help me implement it? Or at least guide me through it? With common. I'm going to try and implement it myself by looking at other applications.

[Aga-C]

Check links I've sent you a few comments before. They point exact lines of code.

[naveensingh]

I'm still a computer science student, could you please help me implement it?

Thanks for your contribution but no. As Agni said above, check how it's done in other Fossify apps.

We won't be "helping" people implement anything as that will invite more and more people who are beginning to learn Android development and helping people learn development is not the mission.