Added Password Protection (whole app and note deletion)

FossifyOrg / Notes

A simple text field for adding quick notes without ads.

https://www.fossify.org

GNU General Public License v3.0

158 stars 15 forks source link

Added Password Protection (whole app and note deletion) #21

Closed WillBBHM closed 3 months ago

WillBBHM commented 5 months ago

I have made the modifications for this second pull request as requested.

What is it?

[ ] Bugfix
[x] Feature
[ ] Codebase improvement

This is the link of the feature request : https://github.com/FossifyOrg/Notes/issues/17

Description of the changes and new features

Added Password protect the whole aplication
Added Password of the app protect notes deletion
Added a new settings section to the settings menu, with a checkbox to enable or disable application password protection. (Request user to create a password)

Screenshots

New Settings "password" added in settings menu:
App protection at start:
Notes deletion protection (after confirmation delete):

Acknowledgement

[x] I read the contribution guidelines.

Aga-C commented 5 months ago

Now app blocking works like in other apps, thanks!

There are few more things to do:

Deletion protection should be a separate option. Check other apps how it works there (Gallery or File Manager). When you'll add this option, please add a new string for it: Password protect note deletion, don't reuse the existing one.
Please move Security section in Settings to be between Saving and Migration.

WillBBHM commented 5 months ago

I've just finished making the small changes requested.

Aga-C commented 5 months ago

I've tested and it works fine. Please now wait for final review from Naveen.

WillBBHM commented 5 months ago

Okay, that's great! I hope for a positive response!!

onegladius commented 5 months ago

Thank you for your work!

WillBBHM commented 5 months ago

Thank you very much, now all that’s left is to wait for Naveen to merge my contribution into the main project!!

theKaido commented 4 months ago

Hello, @naveensingh can we get an estimate of when this pull request will be validated? We need the validation to receive a rating. Thanks you

naveensingh commented 4 months ago

Sorry I can't provide an ETA, it'll reviewed after I'm done updating some other apps and after the Clock app is released. I'll try to get here by the weekend.

theKaido commented 4 months ago

thank you for your answer

naveensingh commented 3 months ago

Looks good to me! Sorry, it took me this long to get here.

theKaido commented 3 months ago

Thank you , Don't Worry about that ;)