FossifyOrg / Phone

A handy phone call manager with phonebook, number blocking and multi-SIM support
https://www.fossify.org
GNU General Public License v3.0
460 stars 42 forks source link

Bring back, "Edit number before call" option #149

Open avatar1024 opened 5 months ago

avatar1024 commented 5 months ago

Checklist

Feature description

Using SMT Call / contact it was possible, from the contact card, to long press on a phone number and it proposed the option "Edit number before call". This is no longer there in this fork.

Why do you want this feature?

It allowed to quick modify a number, for e.g. to add country extension if calling from abroad, or to select a different sim card as it brought up the dialling page (see here: https://github.com/FossifyOrg/Phone/issues/148)

Additional information

No response

Aga-C commented 5 months ago

Are you sure it was in Simple Contacts/Dialer? I've never seen this feature, and I've checked the last versions of Simple Contacts and Simple Dialer, and they didn't have it.

Fossify Phone, same as Simple Dialer, doesn't handle contact cards on itself, they are opened in an app that's set in the system as the default contacts app. Maybe, prior to installing Fossify Contacts you had another contacts' app (not Simple Contacts) set as the default one, and it had this feature?

avatar1024 commented 5 months ago

I'm positive it did. I have used Simple Contact (and all SMTs) for a long while and it's easily distinguishable from the other (installed by default) contact app present on my phone.

I've just tried to reinstall SMT Contact (latest version and a few older version) but it now looks different to what it did before (and indeed looks identical to Fossify Contact). The whole contact card in Fossify Contact and in SMT Contact I've just installed looks different to the one I use to have (and just to confirm the contact card in the contact app installed by default on my Phone is also different to what I used to have so I'm definitely sure it wasn't that).

Maybe I'd been running an old version of SMT Contact but that'd be odd as I remember getting F-Droid updates for it.

So I really don't know, but I guess if you fork the code from SMT contact then it means they must have removed that or something really odd is going on. I guess I could just change the title of this post to Add "Edit number before call" option :)

sphh commented 4 months ago

AFAIR this "Edit number before call" used to be a feature of Simple Dialer, which has been (sadly) dropped in one of the updates.

I also miss that very handy feature!