FossifyOrg / Phone

A handy phone call manager with phonebook, number blocking and multi-SIM support
https://www.fossify.org
GNU General Public License v3.0
465 stars 42 forks source link

Confirmation is not asked if the call is initiated from android stock contacts #243

Closed AnthillSudoku closed 34 minutes ago

AnthillSudoku commented 2 hours ago

Checklist

Affected app version

1.2.0

Affected Android/Custom ROM version

eOS 2.3 (android 13)

Affected device model

samsung a52q

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

  1. Open Fossify Phone
  2. Enable "show a call confirmation dialog before initiating a call" in the settings
  3. Open android stock contacts app
  4. Call a contact

Expected behavior

A confirmation dialog appears

Actual behavior

Call start immediately

Screenshots/Screen recordings

No response

Additional information

I always used fossify contacts + fossify phone and removed stock contacts, so I did not have this issues since I tried reinstalling stock, as users may use other contact apps.

I am not sure if it is related with https://github.com/FossifyOrg/Phone/issues/240#issuecomment-2366092373

However this setting should be respected regardless of who invoke Fossify Phone

AnthillSudoku commented 2 hours ago

Here Fossify Phone is set as the default call app

naveensingh commented 34 minutes ago

this setting should be respected regardless of who invoke Fossify Phone

Showing a confirmation dialog is the responsibility of the app initiating the call.

Under the hood, apps place calls using a ACTION_CALL intent which is then directed to the default phone app. ACTION_CALL is supposed to directly place a call without any confirmation dialog. Hijacking the ACTION_CALL intent to show a confirmation dialog would cause problems like: