search

FossifyOrg / Phone

A handy phone call manager with phonebook, number blocking and multi-SIM support
https://www.fossify.org
GNU General Public License v3.0
450 stars 42 forks source link

Fossify Phone (Contact Tab) and Contacts App not showing any contacts #28

Open Kasi07 opened 7 months ago

Kasi07 commented 7 months ago

Checklist

Describtion No Contacts are visible. The issue started with one of the later versions of the former Simple-Dialer and Simple-Contacts app and seems to persist here. Strangely The correct names are shown in the call history. There was an issue for Simple-Contacts (SimpleMobileTools/Simple-Contacts#1044) which seems to be the same issue. As mentioned in a comment here the versions Simple-Dialer 5.18.0 and Simple-Contacts 6.22.4 are working as intended. I did double check and this holds true for me too.

I suspect this will be a problem in the Fossify Contacts app too.

To Reproduce Steps to reproduce the behavior:

  1. Open Phone
  2. see no contacts

Expected behavior See all contacts.

Screenshots Screenshots can be found in the old issue here: SimpleMobileTools/Simple-Contacts#1044

Helpful Links

Device info (please complete the following information):

Aga-C commented 7 months ago

In which memory do you keep contacts?

Kasi07 commented 7 months ago

I am using bitfireAT/davx5-ose to access them via carddav.

Aga-C commented 7 months ago

Thanks! Please just change the title that you're writing about Contacts tab. Phone doesn't use Contacts app to get the contacts, these are two separate apps.

Kasi07 commented 7 months ago

As the Fossify Contact app has just been released, I have been able to confirm that this bug is also present in the Contact app.

ronniedroid commented 7 months ago

Just want to add that I did not have this issue on android 13, only on android 14 (custom rom)

Rewertius commented 7 months ago

Confirm, can't see my synced Contacts. App Version 1.0.1. Sync with davx5 from mailbox.org via carddav on Pixel 6a with GrapheneOS (Android 14) With the native contacts app, there is no problem.

irgendwie commented 6 months ago

I tried to debug this problem and (at least for me) it boils down to this line of code in the commons library (https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/kotlin/org/fossify/commons/helpers/ContactsHelper.kt#L825). The accounts are correctly read (https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/kotlin/org/fossify/commons/helpers/ContactsHelper.kt#L821) and iterated over but the call to getIsSyncable(…) returns a value different to 1 and therefore no address book gets added.

Afterwards, in this line (https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/kotlin/org/fossify/commons/helpers/ContactsHelper.kt#L840) allAccounts does have all accounts but since accounts "already contains" the account it isn't added in this line (https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/kotlin/org/fossify/commons/helpers/ContactsHelper.kt#L845).

Since I'm not really familiar with Kotlin and/or Android Development I'd be glad if a developer could help. (Especially, since I'm not familiar with the development environment, I wasn't able to add a local copy of the commons library to my the contacts app and manipulate the code to gain further insights.)

Edit: On a side note - There currently is no open issue in the FossifyOrg/Contacts app regarding this issue. Therefore I hijacked this topic, since the bug seems to be within the commons library (or within GrapheneOS?).

rightsaidfred99 commented 6 months ago

It also affects when receiving a call, no saved contact displays, only their real number.

nucular8 commented 6 months ago

I can confirm that after upgrading from LOS 20 (Android 13) to LOS 21 (Android 14) my synced contacts are not shown any more. App version 1.0.0. The filtering option only offers to choose from phone storage and phone storage (not visible by other apps). Contacts app (1.0.1.) is affected in the same way, I just opened an issue. PS. Sync is done with davx5 (https://github.com/bitfireAT/davx5-ose).

czarnyckm commented 6 months ago

I have the same problem with CARDDAV contacts. Works fine with 'koler' or 'contacts you' as well as 'Simple Contacts Pro SE' f-droid version 6.22.4.2 Pro (the Github version is broken since January update) and Fossify Messages 1.0.1

dorianve commented 6 months ago

I'm experiencing a similar issue. For me some synced contacts accounts are showing (with Davx), but I have contacts from tutanota (tuta) and those are not showing whereas they appear in the Google Contacts app (which I'd rather not use).

Fossify Contacts 1.0.1

oliva commented 6 months ago

Just a note: this also affects the calendar app's contact birthday/anniversary import feature

bb1a2 commented 5 months ago

Could this be (highly) prioritized, please? Incoming calls are shown as numbers only and I can't tell who is calling.

lmcj-xyz commented 4 months ago

My contacts are synced using davx5, and this is a problem for Fossify Contacts and Fossify Dialer but only after activating a new profile.

I have two profiles: the main profile I don't run any Google services nor apps from the Play Store, that is the profile with the problem. In the profile where I run Google services I installed the Fossify Contacts app and it displays my contacts just fine.

Before using two profiles I was running the sandboxed google play services, and it was all fine.

As others report, GrapheneOS' contacts and dialer apps can see my contacts form davx5 just fine.

deepakdhanji commented 4 months ago

I'd like to add that, the Phone app is unable to read contacts from AOSP Contacts which has DavX based storage.

Not sure if in order to use Fossify Phone App, I have to use Fossify Contacts as well or can use any other Contacts App.

Edit: as @lmcj-xyz mentioned, in a profile with Sandboxed GSF is installed, the issue doesn't seems to arise. Edit2: But then in that profile, the SIM selection returns empty list.

ZMJGMADHPXWT commented 4 months ago

Mi A3, custom Android 13. I'm keeping my contacts in a Fossify Contacts app and Fossify Phone app can get these contacts only during first launch. During next launch Phone app is telling that there is no access to contacts.

Any workarounds for now?

lmcj-xyz commented 4 months ago

In addition to my comment above, it's worth to notice that only Phone and Contacts fail to see my davx5 contacts after uninstalling the sandboxed Google Play services, but Messages can see them without a problem.

Edit: This may be related to the Phone app showing my contacts only in the call history. So, davx5 contacts cannot be accessed in any way by the Contacts app, but they can be seen in Messages, and in the call history of the Phone app.

bb1a2 commented 4 months ago

I figured out why it is happening in my phone. Storage location. Contacts could see it but Phone couldn't (it was missing from the list).

naveensingh commented 4 months ago

There is a small chance that this might be fixed in version 1.2.0: https://github.com/FossifyOrg/Phone/releases/tag/1.2.0

eagerto-learn commented 4 months ago

Just updated to version 1.2.0 and the issue still persists

Kasi07 commented 4 months ago

Same for me.

naveensingh commented 4 months ago

I could not reproduce the issue on two Android 14 devices. I can't install GrapheneOS at the moment but I have a few ideas so I'll need someone to test things for me. Here is another APK with a potential fix:

phone-4-foss-release-issue-28.zip

(GitHub doesn't support APKs so just rename the .zip to .apk and install, do not extract it)

Kasi07 commented 4 months ago

Still does not work for me.

Any specifics I/We should test?

irgendwie commented 4 months ago

@naveensingh It seems like it only affects Android 14 devices which don't have Google Play services installed (see https://github.com/FossifyOrg/Phone/issues/28#issuecomment-2073233447). I did not test it on a GApps enabled device. I already debugged the problem on my side and found the failing code (see https://github.com/FossifyOrg/Phone/issues/28#issuecomment-1938635900) some time ago. In the meantime I was already able to incorporate a dirty patch, which doesn't make use of the getIsSyncable function (or bypasses it), thereby resulting in a "functional" app. Tldr; The problem is the call to getIsSyncable, which returns an unexpected value. Maybe a bug in Android? I don't know. The problem occurs for both the Phone and Contacts app, as they share the same library (Commons).

dorianve commented 3 months ago

@irgendwie , actually, I think I should mention that I'm on Android 11, stock version (never tinkered with... so far...), with Google Play services enabled, and I'm affected as well ... Interesting.

chesio commented 3 months ago

@irgendwie , actually, I think I should mention that I'm on Android 11, stock version (never tinkered with... so far...), with Google Play services enabled, and I'm affected as well ... Interesting.

Your problem however seems to be related to syncing contacts from specifing app (Tutanota) or am I mistaken? Cause you've written above:

I'm experiencing a similar issue. For me some synced contacts accounts are showing (with Davx), but I have contacts from tutanota (tuta) and those are not showing whereas they appear in the Google Contacts app (which I'd rather not use).

dorianve commented 3 months ago

@chesio indeed. I have 2 contact accounts syncing on this phone:

My understanding was that Fossify was syncing OK in most cases (eg. My "DAVx5 case"), and other times not (eg. My "Tuta case" and other people's issues in this thread).

Do you think it's actually 2 different issues?

chesio commented 3 months ago

My understanding was that Fossify was syncing OK in most cases (eg. My "DAVx5 case"), and other times not (eg. My "Tuta case" and other people's issues in this thread).

Do you think it's actually 2 different issues?

I would say it is a different issue although it manifests itself in the same way (no contacts showing).

Almost all of the commenters in this thread are reporting having problems on Android 14 with custom ROM. Your problem sounds different, so I would recommend that you open a new issue. It might be easier to solve and if someone else is also having issues with Tutanota app, a dedicated issue will be easier to find for them.

sneakybear commented 3 months ago

Same issue here with latest Graphene on a 6a. Profile with no Google services = no contacts Profile with sandboxed Google = contacts I am able to create contacts fine in both.

samuelion commented 1 month ago

Same problem here. No problem with stock app. More funny, no problem with fossify SMS (i know it is anorher app with not so much link with this one, but all my contact are suggested when I start writing a new sms, thus no difficulties to get them while it is not the case with fossify phone and agenda contacts !)

ZMJGMADHPXWT commented 2 weeks ago

no problem with fossify SMS

+1 Also no problem with fossify SMS app here. As for Fossify Phone I can't get or call from "Contacts" bookmark. But I can make calls from "Favourites" bookmark of Fossify Phone. I hope you can fix it.

chept commented 2 weeks ago

Same here.

Google Pixel 7 Pro wtih GrapheneOS

contacts synchronized with a davx account

No problem with stock app

Fossify Contacts show contacts only when Google Play Services installed