FossifyOrg / Voice-Recorder

An easy way of recording any discussion or sounds without ads or internet access
https://www.fossify.org
GNU General Public License v3.0
174 stars 14 forks source link

"Audio source" settings - Clearer names or Add documentation for that #16

Open inson1 opened 6 months ago

inson1 commented 6 months ago

Checklist

Is your feature request related to a problem? Please describe. I'm also quite confused by the options for "Audio source" in the app settings. For example, what does "Android default" mean, and why isn't it the default option?

Could this setting be made clearer or add information about what each option means and how one would choose an audio source?

Describe the solution you'd like title - first would be better

Describe alternatives you've considered title

inson1 commented 6 months ago

https://github.com/SimpleMobileTools/Simple-Voice-Recorder/issues/244

Aga-C commented 6 months ago

In Readme nearly nobody will find it. I think the best would be a short description under each radio button. Alternatively, a new entry in FAQ (in the app).

tanyabouman commented 5 months ago

I think the audio sources in the app correspond to some of the MediaRecorder.AudioSource options from Android.

https://github.com/FossifyOrg/Voice-Recorder/blob/dcdce9a12ebb7c6c2559cd53d64119ce367e5471/app/src/main/kotlin/org/fossify/voicerecorder/helpers/Config.kt#L30-L38

smutax commented 4 months ago

Hi there. Would choosing any of the aforementioned audio sources allow recording of two-way voice or Voip communication? Like "call recorder". Thanks.

tanyabouman commented 1 month ago

Hi there. Would choosing any of the aforementioned audio sources allow recording of two-way voice or Voip communication? Like "call recorder". Thanks.

I don't think you will be able to record calls because VOICE_CALL is an audio source option, but there are some options from the Android API documentation:

smutax commented 1 month ago

Hi there. Would choosing any of the aforementioned audio sources allow recording of two-way voice or Voip communication? Like "call recorder". Thanks.

I don't think you will be able to record calls because VOICE_CALL is an audio source option, but there are some options from the Android API documentation:

  • VOICE_COMMUNICATION Microphone audio source tuned for voice communications such as VoIP. It will for instance take advantage of echo cancellation or automatic gain control if available.
  • VOICE_CALL Voice call uplink + downlink audio source Capturing from VOICE_CALL source requires the Manifest.permission.CAPTURE_AUDIO_OUTPUT permission. This permission is reserved for use by system components and is not available to third-party applications.

Thanks for clarifying. I don't suppose you know, or if it's at all relevant. What Android API feature music recognition applications such as Shazam take advantage of, as they allow recognition of sound(music) internally , from another application, hence my assumption that they can capture audio output? Sorry if above is confusing.

tanyabouman commented 1 month ago

Thanks for clarifying. I don't suppose you know, or if it's at all relevant. What Android API feature music recognition applications such as Shazam take advantage of, as they allow recognition of sound(music) internally , from another application, hence my assumption that they can capture audio output? Sorry if above is confusing.

I don't know anything about the internals of Shazam, but I'd guess that Capture audio playback is probably similar.