FossifyOrg / Voice-Recorder

An easy way of recording any discussion or sounds without ads or internet access
https://www.fossify.org
GNU General Public License v3.0
174 stars 14 forks source link

mp3 should be the automatic file extension type #35

Open RustoMCSpit opened 4 months ago

RustoMCSpit commented 4 months ago

Checklist

Feature description

make .mp3 the default audio format. not to be rude but closing this last time was pedantic.

Why do you want this feature?

m4a is not foss and it should say that in the 'select file type menu'

Describe alternatives you've considered: on first open of the app ask the user to input desired file extension and clarify that m4a isnt foss

Additional information

just make mp3 the default until flac is integrated / opus is fixed

Aga-C commented 4 months ago

As Naveen said in your previous request, we'll change default to MP3. However, we probably won't change it to FLAC or Opus. We don't want to enforce users into saving recordings that can take much space (FLAC). We don't plan on setting Opus as default until it will work on every Android (currently it's for 10+).

osering commented 4 months ago

As Naveen said in your previous request, we'll change default to MP3. However, we probably won't change it to FLAC or Opus. We don't want to enforce users into saving recordings that can take much space (FLAC). We don't plan on setting Opus as default until it will work on every Android (currently it's for 10+).

It is misleading to say, that opus does not work with Android 9-. Opus codec is recognized starting with Android 5 (A5 - .webm, .mka, .mkv extensions, A7-A9 - .ogg & .oga extensions, A10-A14 - .opus and all all others), opus extension recognized starting with mainstream Android 10 (Lineage 16 (Android 9)). https://en.m.wikipedia.org/wiki/Opus_(audio_format)#Operating_system_support So, just according to Android version extension shall be changed, leaving file the same. Therefore there could be 2 solutions: 1) app according to Android version offers right extension to opus files, or 2) let user to choose extension manually in the app.

Moreover there is question - how recognition/compliance is defined/measured - by capabilities of operating system itself, by (outdated, 5 years+ not-updated) file manager capabilities (of knowing what to do wilt .opus file) or by outdated music player capabilities (modern, up-to-date players shall open/play .opus even if installed on older operating system. So most probably old (neglected) applications and not operating system itself is to blame. For example, try using fresh FX File Explorer and Vanilla Music or Poweramp...

Even by mere count, we can see, that opus partial compliance is alleged in Android 5, 6-9, full 10-14. So majority to date is compliant fully.

Most probably opus codec will never ever play on Android 4 and more ancient as nobody most probably will backport it - so as can be understood - .opus never will be default in this app?

Aga-C commented 4 months ago

@osering I said we don't plan on setting Opus as default until it will work on every Android, because Fossify Voice Recorder supports it from Android 10+.

osering commented 3 months ago

So never :D P.S. You were now specific enough on at what level compliance is measured - OS codec, some file manager, stock player availability... https://developer.android.com/media/platform/supported-formats