Changed default sampling rate (#32) - Githubissues

FossifyOrg / Voice-Recorder

An easy way of recording any discussion or sounds without ads or internet access

https://www.fossify.org

GNU General Public License v3.0

174 stars 14 forks source link

Changed default sampling rate (#32) #37

Open Aga-C opened 4 months ago

Aga-C commented 4 months ago

What is it?

[X] Bugfix
[ ] Feature
[ ] Codebase improvement

Description of the changes in your PR

Changed default sampling rate from 44.1 kHz to 48 kHz, so there's no need to write any conditions to check for Opus.
Tested on real mobile and recording in 48 kHz works correctly for each of three file types.
I've also cross-tested with the released version and Opus now sounds as it should.
We can let users change to 44.1 kHz with implementing #33 in the future.

Fixes the following issue(s)

Fixes #32

Acknowledgement

[X] I read the contribution guidelines.

David-Else commented 2 months ago

Any idea when this and https://github.com/FossifyOrg/Voice-Recorder/pull/36 will be merged?

Aga-C commented 2 months ago

It should be merged before the release of the next version, but I can't tell you when exactly it will happen. Please wait patiently.