FossifyOrg / Voice-Recorder

An easy way of recording any discussion or sounds without ads or internet access
https://www.fossify.org
GNU General Public License v3.0
260 stars 19 forks source link

java runtime exception when pushing record 2x (too) fast #44

Open GuitarBilly opened 8 months ago

GuitarBilly commented 8 months ago

Checklist

Affected app version

1.0.0

Affected Android/Custom ROM version

Android 7.1.2

Affected device model

Nokia 6 - TA-1033

How did you install the app?

Google Play Store

Steps to reproduce the bug

  1. select the Recorder tab
  2. press the record microphone icon twice within 1sec
  3. "java.lang.RuntimeException: stop failed" is displayed in the screen

Expected behavior

I pressed the microphone twice in user error, as I attempted to start a recording.

Not sure how you want to deal with the situation that a user start and stops a recording within the first second. That could be on purpose or not.

Actual behavior

Voice Recorder (VR) app does not crash. VR does create a 00:00 recording file but that cannot be played. If you press play on the 0sec recording VR skips to next file and plays that one instead.

Screenshots/Screen recordings

screenshot:

Screenshot_20240315-074140

Additional information

00:00 recording file. remove the .MP4 from the name as GH did not allow the .m4a extention. https://github.com/FossifyOrg/Voice-Recorder/assets/38086529/cc542c7b-65d9-46f4-ba4c-c9cda167dc43

Cwpute commented 4 months ago

I'd say in most cares people don't want to makc such short recordings, so my opinion would ée to delete every recording below 1 second. But if people are maybe too fast, or do want such a short recording for some reason, enable an option for it.