search

FossifyOrg / Voice-Recorder

An easy way of recording any discussion or sounds without ads or internet access
https://www.fossify.org
GNU General Public License v3.0
224 stars 20 forks source link

mp3 should be the automatic file extension type #6

Closed RustoMCSpit closed 7 months ago

RustoMCSpit commented 10 months ago

Describe the solution you'd like on first open of the app ask the user to input desired file extension and clarify that m4a isnt foss

Describe alternatives you've considered just make mp3 the default until flac is integrated / opus is fixed

Aga-C commented 10 months ago

Please adjust your feature request report to the issue template.

RustoMCSpit commented 9 months ago

whats needs triage mean? edit: just looked it up, honestly this is such an easy fix that it doesnt 'need triage', i imagine youd just change a single variables initial state and it's done

Aga-C commented 9 months ago

This label means: Issue is not yet ready for PR authors to take up. We're waiting for the issue template to be filled out properly.

RustoMCSpit commented 9 months ago

This label means: Issue is not yet ready for PR authors to take up. We're waiting for the issue template to be filled out properly.

thats pedantic but okay

Aga-C commented 9 months ago

@naveensingh Can you check this and decide whether it should be done?

inson1 commented 9 months ago

https://github.com/SimpleMobileTools/Simple-Voice-Recorder/issues/234

naveensingh commented 9 months ago

https://github.com/SimpleMobileTools/Simple-Voice-Recorder/issues/1 https://github.com/SimpleMobileTools/Simple-Voice-Recorder/issues/21 https://github.com/SimpleMobileTools/Simple-Voice-Recorder/issues/62

Support for 'real' MP3 format was added in https://github.com/SimpleMobileTools/Simple-Voice-Recorder/pull/114. I haven't done much work on the Voice Recorder but I think the M4A stayed the default because:

So we will switch to MP3 but if it causes any problems among the uninitiated users, I'm switching it back to M4A until MP3 works properly.

honestly this is such an easy fix that it doesnt 'need triage', i imagine youd just change a single variables initial state and it's done

@RustoMCSpit it has nothing to do with easy. In projects like this, one must carefully consider the consequences before changing even a small constant. If we don't, it won't be long before the whole project is a mess that only works properly for a small group of people. When working with SMT, we often broke things even when we were sure we had considered every possible use case.