search

Fossj117 / NBAdata

Contains scraper in R for grabbing NBA Sport Tracking Data
54 stars 39 forks source link

pullPositions #2

Open WillMatteson opened 7 years ago

WillMatteson commented 7 years ago

First off, thanks for publishing this. I've tried to use the pullPositions script on an updated nba.csv file using your r scraper but so far I'm not having luck generating the new csv positions file. The script seems stuck, from poking around it seems like there are a lot of individual queries involved but it's been running for over an hour without any output. Got any advice?

Thanks -Wm

Fossj117 commented 7 years ago

Hey Will I unfortunately don't actively maintain this project at the moment. I'd suggest playing around with the script and maybe print some more debugging info to see if you can figure out where it's hanging. The script is really simple it just pings the API with each player ID and then dumps the results into a CSV.

Btw, it's possible the API that this pulls from has been changed/deprecated. The other issue on this repo might have some helpful ideas.

Good luck and feel free to send a PR if you're able to figure this out!

WillMatteson commented 7 years ago

Hey Jeff,

Thanks for the response, sorry to hear that you’re not continuing the maintain the repository. I’ve been monkeying around with the code and will send a PR if I come across anything helpful. The code also currently doesn’t capture all NBA players, on my last run it captures about 200 rows. I think this could be because each json also contains <250 players, again will lyk if there are any easy fixes.

Overall as a fledgling (or wannabe) data scientist currently in undergrad do you have any advice?

-Will

On Apr 27, 2017, at 4:26 PM, Jeff Fossett notifications@github.com wrote:

Hey Will I unfortunately don't actively maintain this project at the moment. I'd suggest playing around with the script and maybe print some more debugging info to see if you can figure out where it's hanging. The script is really simple it just pings the API with each player ID and then dumps the results into a CSV.

Btw, it's possible the API that this pulls from has been changed/deprecated. The other issue on this repo might have some helpful ideas.

Good luck and feel free to send a PR if you're able to figure this out!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fossj117/NBAdata/issues/2#issuecomment-297829448, or mute the thread https://github.com/notifications/unsubscribe-auth/AYvCK4RLi3j5BRefo8wdM8RjqSEBHG17ks5r0PnugaJpZM4NJTfO.

Fossj117 commented 7 years ago

@WillMatteson Sounds good.

In terms of getting into data science, my general thoughts are to learn as much as you can (about different tools, methods, areas etc.) and figure out what you're interested in, build a portfolio (good for both experience & when you're applying to jobs), and then talk to as many people as possible in the field.

Some good advice from a former colleague here and here. Good luck!