FosterCommerce / shipstation-connect

A plugin for Craft Commerce 2 that integrates with ShipStation.
https://plugins.craftcms.com/shipstationconnect
Other
7 stars 10 forks source link

Orders do not import properly when 'Billing address same as shipping address' disabled. #25

Closed oadslug closed 3 years ago

oadslug commented 3 years ago

Currently, orders do not import if the setting 'Billing address same as shipping address' is disabled and the order does not have a billing address.

The problem is in /services/xml.php in the shouldInclude() method (line 19) when building the orders xml object.

I assumed that disabling this setting would simply leave the billing info empty, but instead it excludes the order from the orders xml. Off the top of my head, I don't know if 'billing address' is required by ShipStation or not. If not, then this should be fixed. If billing address is required, then the plugin is behaving properly, but I would recommend adding a warning in the setting description that 'Orders that do not have billing address will not be imported'.

Thanks.

johnnynotsolucky commented 3 years ago

@oadslug indeed customer billing information is required by ShipStation: https://help.shipstation.com/hc/en-us/articles/360025856192-Custom-Store-Development-Guide

image

Your suggestion to include a warning label is a good one. We'll add that.

oadslug commented 3 years ago

Great. Thank you for clarifying. Much appreciated!