search

FosterCommerce / shipstation-connect

A plugin for Craft Commerce 2 that integrates with ShipStation.
https://plugins.craftcms.com/shipstationconnect
Other
7 stars 10 forks source link

Replace deprecated getShippingMethod function #58

Closed sajjanstha closed 7 months ago

sajjanstha commented 7 months ago

Task/Ticket

Summary of the changes:

I did this because

The main changes are

johnnynotsolucky commented 7 months ago

Thanks for the PR @sajjanstha. However this change has already been applied as part of the work to get the plugin ready for Craft 4: https://github.com/FosterCommerce/shipstation-connect/commit/b37e54d40edac366b75fc9a2b44e14fb8cf4c0e7.

If possible, I suggest upgrading to v2.0.3 of the plugin and testing whether there's a performance improvement.

sajjanstha commented 7 months ago

Thanks for the PR @sajjanstha. However this change has already been applied as part of the work to get the plugin ready for Craft 4: b37e54d.

If possible, I suggest upgrading to v2.0.3 of the plugin and testing whether there's a performance improvement.

@johnnynotsolucky Currently we are in the process of updating to craft 4 but it's taking longer than expected as the project is big. In the mean time, we were facing an issue where syncing shipstation store with our craft server were taking really long and failing the sync. This changes fixed the issue. Please reconsider releasing this change for Craft 3 as well since the $order->getShippingMethod() is deprecated and makes unnecessary database calls as shippingMethodHandle and shippingMethodName is avaiable in orders table itself.

johnnynotsolucky commented 7 months ago

@sajjanstha I've made v1.4.0 with your change. Please let me know if this works for you?