search

FosterCommerce / shipstation-connect

A plugin for Craft Commerce 2 that integrates with ShipStation.
https://plugins.craftcms.com/shipstationconnect
Other
7 stars 10 forks source link

Stringy Naming Collision #8

Closed jmauzyk closed 5 years ago

jmauzyk commented 5 years ago

Just installed Craft 3.3 and was starting to test it when I ran into a naming collision issue with Stringy. Craft 3.3 switches from danielstjules/Stringy to voku/Stringy. This wouldn't be an issue except that Craft 3.3 now uses the snakeize() method (unique to voku) for the |snake twig filter. Because composer defaults to the old danielstjules/Stringy when generating autoload files, I now get a call to undefined method error when using the snake filter. Can you switch from the danielstjules version to the voku version to avoid this collision?

jmauzyk commented 5 years ago

Dug into this a bit more, looks like it is specifically the composer.lock file that has a reference to Stringy and is causing issues.

sjcallender commented 5 years ago

@jmauzyk We haven't tested this with Craft 3.3 yet.

johnnynotsolucky commented 5 years ago

We shouldn’t be including the lock file in the plugin. composer.json is sufficient. I’ll update.

jmauzyk commented 5 years ago

Thanks, guys!

johnnynotsolucky commented 5 years ago

@jmauzyk this should be resolved in v1.2.2. Let me know if this works, and I'll close this issue.