search

FotonTech / burn

:fire: BURN a React Native boilerplate
118 stars 5 forks source link

Set node version to up 9.10.0 #8

Closed miltoneiji closed 5 years ago

miltoneiji commented 6 years ago 
error eslint@5.6.0: The engine "node" is incompatible with this module. Expected version "^6.14.0 || ^8.10.0 || >=9.10.0".

Just to make more clear that the node version should be >= 9.10.0

jgcmarins commented 6 years ago

even better: should be the same as react-native 8.3 https://github.com/facebook/react-native/blob/bd8b942ab9d265fa266dc4ae6bb00eabd2028698/package.json#L11

miltoneiji commented 6 years ago

@jgcmarins the problem is that eslint@5.6.0 needs version ^6.14.0 || ^8.10.0 || >=9.10.0. So, it cannot be the LTS version (v8.9.0) neither react-native version (v8.3).

But since react-native accepts >=8.3, I think that 9.10.0 or greater should be ok, right?

jgcmarins commented 6 years ago

^8.10.0 means that v8.9.0 is ok same for >=8.3 besides that, node foundation does not recommend versions above LTS

miltoneiji commented 6 years ago

Hmm thanks, I was not considering that ^8.10.0 matches 8.x.x hahaha. I fixed to 8.12.0, that's the latest LTS version right now (https://nodejs.org/en/)

socksrust commented 5 years ago

nice