updated service bus with new microsoft.azure.servicebus dotnet library

[shahbarkha]

• First cut that allows the foundatio.azureservicebus to use the latest azure service bus dotnet library ( 1.0.0)
• Added 2 sample apps for topics and queues

[CLAassistant]

All committers have signed the CLA.

[shahbarkha]

No Blake it’s not implemented yet in the new 2.0 version

Thank you Sent from my iPhone - Barkha shah

On Oct 30, 2017, at 7:47 AM, Blake Niemyjski notifications@github.com wrote:

@niemyjski commented on this pull request.

In src/Foundatio.AzureServiceBus/Messaging/AzureServiceBusMessageBus.cs:

@@ -151,14 +204,14 @@ public class AzureServiceBusMessageBus : MessageBusBase<AzureServiceBusMessageBu if (_options.TopicEnableExpress.HasValue) td.EnableExpress = _options.TopicEnableExpress.Value;

• if (!String.IsNullOrEmpty(_options.TopicUserMetadata))
• td.UserMetadata = _options.TopicUserMetadata;
• //if (!String.IsNullOrEmpty(_options.TopicUserMetadata))
• // td.UserMetadata = _options.TopicUserMetadata; @shahbarkha Azure/azure-sdk-for-net#3635 Any idea if this is now supported?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[niemyjski]

Looks great!! Awesome job. Do you feel like we should merge it in or merge it into a branch? Guess we could merge it in and just bump the major again or put it in preview until the management stuff gets done

[niemyjski]

@SeanFeldman would you mind reviewing this and leaving your comments to my last question :) Thanks in advance

[niemyjski]

Let me know when you want me to merge this in :)

[shahbarkha]

@niemyjski I liked your idea of putting this stuff on the preview untill the management stuff is released. Also I want to do the benchmark thing going on before we merge it in the master.

[niemyjski]

Thanks for the PR! I've merged this into the .net standard branch. We'll push a preview build out shortly. We might have to wait until the logging release goes out as that's going to be a stable build and then this one so it's a higher nightly preview build or bump the major on this

[SeanFeldman]

@SeanFeldman would you mind reviewing this and leaving your comments to my last question :) Thanks in advance

Sorry @niemyjski, was away on vacation. Looks like a bit late to review 😃