Fix ToString of negated groups

FoundatioFx / Foundatio.Parsers

A lucene style query parser that is extensible and allows modifying the query.

https://www.nuget.org/packages/Foundatio.Parsers.LuceneQueries/

Apache License 2.0

66 stars 20 forks source link

Fix ToString of negated groups #50

Closed LucidSage closed 4 years ago

LucidSage commented 4 years ago

Currently a query like "NOT someField:(stuff)" will get transformed into "someField:(stuffNOT )", which is causing issues in our system. TermNode does not have this behavior. This change keeps the ToString behavior consistent between TermNode and GroupNode (as well as fixing a bug).

CLAassistant commented 4 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Darren seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

LucidSage commented 4 years ago

@ejsmith Thanks for the quick turn around on that! When can we expect that fix to show up in NuGet? Just trying to plan whether we need to use our own fork as a stop gap so any rough guess on this would be helpful :)

ejsmith commented 4 years ago

@LucidSage we aren't ready to push new official releases just yet, but it won't be too long. In the meantime, you can use the https://feedz.io packages by adding a nuget source like here: https://github.com/FoundatioFx/Foundatio.Parsers/blob/master/NuGet.config

LucidSage commented 4 years ago

@ejsmith That works for me! Thanks again for the help :)