search

FoundatioFx / Foundatio.Redis

Foundatio Redis
Apache License 2.0
98 stars 31 forks source link

use IConnectionMultiplexer instead of ConnectionMultiplexer #11

Closed bdrupieski closed 5 years ago

bdrupieski commented 5 years ago

Thanks for building this library. It's been tremendously useful for my project and has saved us so much time.

I'm trying to trace Redis calls with OpenTracing by using my own IConnectionMultiplexer implementation that returns my own IDatabase implementation. However I can't use it with Foundatio.Redis because the configuration requires a ConnectionMultiplexer instead of an IConnectionMultiplexer.

Changing Foundatio.Redis to take the interface instead appears to be as simple as changing it in these options classes and an extension method. It compiles and all tests pass for me.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

ejsmith commented 5 years ago

Looks good to me. I will get this merged in as soon as the build passes.

ejsmith commented 5 years ago

@bdrupieski this change is out on nuget now. Thanks!

bdrupieski commented 5 years ago

Holy cow! What an amazing turnaround time. Thank you!

niemyjski commented 5 years ago

Thanks for the PR!