search

FoundatioFx / Foundatio.Redis

Foundatio Redis
Apache License 2.0
98 stars 31 forks source link

Change script timeouts to be in milliseconds #75

Closed ejsmith closed 3 years ago

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

syntx commented 3 years ago

@ejsmith Thanks! This should work well for my scenario. Small suggestion: I noticed that you added a test for early expiration - you might want to add a call to RenewAsync there so the Lua script is called.

syntx commented 3 years ago

@ejsmith,

@ejsmith Thanks! This should work well for my scenario. Small suggestion: I noticed that you added a test for early expiration - you might want to add a call to RenewAsync there so the Lua script is called.

Ah, if the tests are using an InMemoryCacheClient it won't be called.

ejsmith commented 3 years ago

@syntx just added a renew lock call in the test.