search

FoundatioFx / Foundatio

Pluggable foundation blocks for building distributed apps.
Apache License 2.0
1.96k stars 243 forks source link

downgraded librraries to support .NET Core 3.1 LTS. #263

Closed RobK410 closed 2 years ago

RobK410 commented 3 years ago

Need

There exists a need to be able to support applications and libraries written to the .NET Core 3.1 Long Term Support (LTS) version of .NET. .NET 3.1 is to be supported through 2022.

Problem Currently, The core Foundatio library references 5.0 versions of a few libraries that break the support for .NET Core 3.1 and require .NET Core 5.0, a non-LTS version of .NET.

Solution

Roll back the libraries that force .NET 5.0 to their latest respective 3.1.x versions.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

RobK410 commented 3 years ago

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. Rob Kennedy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.

I've completed this SLA several times and redirected back here, but it continues to show the error that I've not signed the SLA. I sign in with my GitHub account successfully, and click the sign SLA button and redirect back successfully. Still no joy.

niemyjski commented 3 years ago

Hello, Thanks for the PR.

We need to discus this with the team and see if we can downgrade the deps, I think we ran into multiple issues when we upgraded all of our apps to 5.0. Ideally we would track the LTS but we have limited bandwidth in supporting multiple versions. Is there something in the newest release that resolves an issue you are running into? In the mean time until a discussion is had, I'd recommend sticking on v10.0.2 which tracks .NET Core 3.x. We should have bumped the major for the .NET Core 5.x change.

I'm wondering if the CLA isn't working due to the commit email address differs from your github email address?

RobK410 commented 3 years ago

Hello, Thanks for the PR.

We need to discus this with the team and see if we can downgrade the deps, I think we ran into multiple issues when we upgraded all of our apps to 5.0. Ideally we would track the LTS but we have limited bandwidth in supporting multiple versions. Is there something in the newest release that resolves an issue you are running into? In the mean time until a discussion is had, I'd recommend sticking on v10.0.2 which tracks .NET Core 3.x. We should have bumped the major for the .NET Core 5.x change.

I'm wondering if the CLA isn't working due to the commit email address differs from your github email address?

Hello, Thanks for the PR.

We need to discus this with the team and see if we can downgrade the deps, I think we ran into multiple issues when we upgraded all of our apps to 5.0. Ideally we would track the LTS but we have limited bandwidth in supporting multiple versions. Is there something in the newest release that resolves an issue you are running into? In the mean time until a discussion is had, I'd recommend sticking on v10.0.2 which tracks .NET Core 3.x. We should have bumped the major for the .NET Core 5.x change.

I'm wondering if the CLA isn't working due to the commit email address differs from your github email address?

Thanks for the response. I understand the needs of .NET 5 vs 3.1. Hopefully this all gets resolved in Nov with .NET 6. I know my team tracks with LTS versions only since we don't have the bandwidth either to support the interim releases like 5.

Probably wouldn't need to upgrade JSON.net in the PR I submitted, and I did try to research the diffs in libraries between 3.1.16 and 5.x versions, I didn't see anything outstanding, but again, Microsoft's docs are limited, as is our time. The changes built ok, and compiled ok with my 3.1 projects.

If I grab some time (🙏🏻 ) I'll see about testing with a 5.0 project runtime.

Regarding the CLA, I'll research into it. Not sure why it's conflicting emails, it asks to login via GitHub which is successful, but I'll look into it. Hopefully that can get resolved. Cool little service I may use in my own projects in the future.

Thanks, Rob