NCR/LEGION/MELEE OVERHAUL + Enclave Private Nerf

[SirSwagmeyer]

About The Pull Request

Introduces a new set of heavy trench raider armor for all of your melee-oriented needs. Loadouts included in the Corporal and HT loadouts. Reworks the shock trooper HT loadout. Sorry in advance for the sloppy code. It SHOULD work.

Took some community feedback regarding the lackluster qualities of the NCO and CO loadouts, and gave them a couple minor buffs.

Spend a few hours taking in community feedback regarding Legion and Melee. Gives actual incentive to use melee, gives lesser-used Legion roles some actually decent gear.

Nerfs mass-produced Enclave armor because it was borderline roundstart CA.

Why It's Good For The Game

I coded in some of the community feedback, and the discussion of better loadout options for Corporal and Heavy Trooper came up. New armor is always fun. Melee Legion has someone to fight against now.

These buffs will allow more uncommon NCR roles to compete with Legion equivalent roles, and incentivize people playing these roles more as well. I know the traits seem like a lot, but it really isn't when you look at the vast amounts of traits Legion spawn with. The community feedback from the discord had a lot of discussion regarding how little reason there is to play Staff Sergeant - turns out, the traits were pathed wrong. I fixed that as well.

Buffing melee weapons (1H, 2H, Unarmed) incentivizes melee combat more than backpedaling and going pew pew with a Tier 5/6 gun. A lot of melee weapons have a bit more bite against plated armor and wound more. Throwable weapons are also better baby wooo

Legion loadouts were littered with buggy code and half-baked items that haven't been changed in months. Giving them all a little update should encourage more of the player base to play Legion.

Pre-Merge Checklist

• [x] You tested this on a local server.
• [x] This code did not runtime during testing.
• [x] You documented all of your changes.

Changelog

:cl: add: Added the heavy trench raider armor set add: Added a new Melee HT loadout. add: Added the new armor to the Corporal melee loadout. balance: Gave the HT a BAR instead of the Citykiller. Shotguns are unfortunately just not able to keep up. add: Added trekking to Staff Sergeant, Sergeant, and Combat Medic. add: Added Big Leagues to Captain and LT. add: Added traits that other COs had for Staff Sergeant (lifegiver, big leagues, self-aware). add: Added two separate loadouts to Staff Sergeant: Sharpshooter and Man-At-Arms. add: Reworked the Vex, Warlord Cent, Frumentarius, Explorer, and Vet Decanus loadouts. add: Added slight AP to several Legion weapons. tweak: Slightly enclave private armor so that it isn't roundstart CA. tweak: Threw in a unique trench raider armor for a Corporal loadout. balance: Legion armor slowdown is VERY slightly faster now. balance: Several 2H, 1H, and Unarmed weapons deal more damage, have small amounts of AP, or do extra wound. balance: Lowered mass-produced enclave armor's bullet and wound protection. balance: Throwing spear embed chance is higher now; deals more throw damage. fix: Vet Decanus loadouts are no longer bugged. /:cl:

[SirSwagmeyer]

God damn it Github didn't make a new branch

[xTrainx]

change all spaces you used for tabs

[SirSwagmeyer]

change all spaces you used for tabs

Oh god I had two spaces on ONE LINE 😭

[BadAtThisGame302]

Not sure why you are giving even more NCR trekking same as big leagues, also removing ranger cent slowdown and nerfing normal cent slowdown. None of these are in the changelog, same as nerfing enclave combat armor? Why are half of these changes you make good for the game?

I suggest you stick to adding the new loadout and reverting the other changes.

[SirSwagmeyer]

Not sure why you are giving even more NCR trekking same as big leagues, also removing ranger cent slowdown and nerfing normal cent slowdown. None of these are in the changelog, same as nerfing enclave combat armor? Why are half of these changes you make good for the game?

I'm taking COMMUNITY FEEDBACK. I ask people in the discord and in the server exactly what they want to see be improved for the better, and then I code accordingly. I do not code anything off of personal preference, I simply do what the community suggests. Of course, if the suggestions are ridiculous, I don't do them (like giving CE rockets again or something), but I genuinely don't think these changes are bad.

You say "even more NCR trekking", but all I really did was give CM, Staff Sergeant, and Sergeant trekking, which absolutely makes sense to me. Prime, Recruit, and Veteran Decanus have iron fist, big leagues, AND trekking. I think it's a little ridiculous balance-wise that senior NCOs get literally nothing. Staff Sergeant was supposed to have CO traits anyway. And I only gave big leagues to the NCOs and COs with melee loadouts - this is fair and balanced considering how underwhelming melee is compared to the massive guns powercreep that's been plaguing the game lately if you've noticed in-game. I'm trying to incentivize other means to play the game and engage in fights.

Regarding Legion, I have never, not ONCE, seen someone play Ranger Cent. And why? Because it's the worst armor in the game out of all the other Cent loadouts. It has zero benefit other than having slightly less slowdown, but still having more slowdown than most Legion armor. It has ridiculous slowdown for a loadout that's supposed to be for fast-paced skirmishes, and the AMR makes the slowdown even worse. It is objectively not worth the stats or even the time to pick it. Removing slowdown gives people at least A LITTLE MORE incentive to pick that role, and that's good enough for me.

Regarding the default Centurion Armor, that armor is dedicated to Warlord Centurion, which is MELEE ORIENTED, yet has the same amount of slowdown as PALACENT armor. That was a suggestion made by a lot of Legion players who were trying out the Centurion role and being discouraged from it because of the underwhelming stats. I lowered the slowdown on the warlord cent armor to incentivize Legion to engage in more fast-paced guerilla tactics. This incentive is increased by the melee weapons buff.

And I just forgot to add the enclave private armor nerf to the changelog, that's my bad. They shouldn't have roundstart CA though.

I'm not sure if you've played on the server in the past few months or so, but there's been a lot powercreep and a legacy of grudgecode built up over the months that I'm trying to address here. This PR is done out of the goodness of the community, and not out of personal desire.

[BigBigga]

based

[Loldaddy5676]

ah yes, 2 or maybe 3 roles? get weaken combat armor, such a powerful start..... even though bos initiates and knights(aka 5-6 roles?) already spawn with real combat armor and even two sets of reinforced combat armor to boot.

[SirSwagmeyer]

ah yes, 2 or maybe 3 roles? get weaken combat armor, such a powerful start..... even though bos initiates and knights(aka 5-6 roles?) already spawn with real combat armor and even two sets of reinforced combat armor to boot.

Then go make the PR removing the combat armor from the BoS. I'd remove Enclave as a whole if I could.

[RonBag]

My concern regarding this is the amount of changes backed into one PR. The actual code and numbers are mostly okay, though things like trekking I disagree with.

[SirSwagmeyer]

My concern regarding this is the amount of changes backed into one PR. The actual code and numbers are mostly okay, though things like trekking I disagree with.

I understand the concerns. This was one big passion project, culminated from a whole week's worth of communicating with the playerbase on suggestions that they had for balancing the overall gameplay of the server. I've reviewed all the code pretty thoroughly, and I had Train walk me through the difficult parts. I don't think the merge will be a problem.

I'm willing to take trekking out of some of the roles if it means I have a chance to testmerge this, as well as any other compromises regarding traits.

[SirSwagmeyer]

I'm fucking stupid I didn't mean to close that

[Aurrain]

This honestly needs to be cut-up into separate PRs, it's a huge mess of changes that are a mix of new additions and questionable changes made from 100% refined player salt and outrage. My advice is to start w/ the new stuff and add the other bits in other PRs where we can go-over what's good and isn't.

[BigBigga]

I LOVE THE BAR

[xTrainx]

solve the conflics please

[SirSwagmeyer]

solve the conflics please

Which ones?

[BigBigga]

untestmerged. joever. the HT loadouts are excellent (shotguns are dogshit so really, anything that replaces the city-killer one is great). but i see some people salting abt the trench raider stuff mainly because corporals get the option to pick the loadout and corporal is 4 slots. maybe keep the option for HTs to pick it roundstart and make it so 1-2 sets of trench raider spawn in the secure armory? that way corporals can still get it but not roundstart, and not for all of them. just a thought, idk.

for the love of GOD keep the HTs loadout though i fucking loved them in spite of the tank-like slowdown

[spackorp]

definitely needs to be split into separate prs this is a mess.

[SirSwagmeyer]

definitely needs to be split into separate prs this is a mess.

That's the thing, what makes it a mess? I made it into separate PRs beforehand, and I was told by a maintainer that I should condense it into one since the separation made it cluttered.

All the checks are passed and I've made distinct clarifications and justifications in the changelog. I've received overwhelming amounts of positive feedback, despite what Tadano says.

Sure, the changes are controversial, but I'm willing to make changes within this PR. Just give me a chance.

[SirSwagmeyer]

Messy code and I already made separate tested PRs for this.