search

Foundation-Devices / tor

Tor plugin for Flutter
https://pub.dev/packages/tor
MIT License
18 stars 9 forks source link

Change plugin name and author #12

Closed icota closed 1 year ago

icota commented 1 year ago

tor_ffi_plugin is kind of wordy and template-y. It doesn't reflect the grand ambitions this project has.

icota commented 1 year ago

@sneurlax I hope you guys don't mind! tor is what it used to be before we FFI'd it and IMO it's a much better name with regards to #2

icota commented 1 year ago

I tested this change on Linux and Android and it was all fine

sneurlax commented 1 year ago

@sneurlax I hope you guys don't mind! tor is what it used to be before we FFI'd it and IMO it's a much better name with regards to #2

hey don't git blame me :) the rename came alongside the cargokit refactor for which I can't take credit

sneurlax commented 1 year ago

it should be fine, there were just issues with cargokit being happy when a rename was tried before

it might cause our repos to diverge briefly if mac and ios references (if any) aren't changed, but there's nothing wrong with it in principle, and the rename was sort of unintentional and just borne out of the cargokit troubleshooting process