Foundation-for-Jekyll-sites / jekyll-foundation

Start your Jekyll (v3) project with Zurb Foundation for Sites (v6, sass).
MIT License
179 stars 64 forks source link

[Pagination] Page 1 link broken #54

Closed andycochran closed 7 years ago

andycochran commented 7 years ago

I thought this might be related to a typo on index.html line 35:

'/seite:num'

^ Should this be '/site:num' or '/page:num'?

I've tried both. But the page 1 URL (when on other pages) is still set as http://127.0.0.1.xip.io:3000/blog/page:num.

andycochran commented 7 years ago

Also, per Foundation docs, the current page does not need the <a> tag.

I've replaced lines 33-35 with the following, which works for me.

...
    <li class="current">{{ page }}</li>
{% elsif page == 1 %}
    <li><a href="{{ site.baseurl }}/blog/">{{ page }}</a></li>
...

I can PR if you like this change.

kculmback commented 7 years ago

I think I have fixed the issue you are having. I changed the markup to directly match what is suggested on the jekyll website, which seems to be working.

I'll submit a pull request, but it may be worth testing before it's committed. You can find the code here. @core77 do you want to take a look at this as well?

It should be worth noting that this also utilizes the plugin setup I mentioned here #55

core77 commented 7 years ago

If this is resolved through kckulmback's PR, would someone close this? I have only iOS devices around me and no possibility to test :-(

kculmback commented 7 years ago

Closed since there seems to be no further issues!