Foundation-for-Jekyll-sites / jekyll-foundation

Start your Jekyll (v3) project with Zurb Foundation for Sites (v6, sass).
MIT License
179 stars 64 forks source link

Fix pagination issue, remove unnecessary pagination links, and change how plugins are loaded #57

Closed kculmback closed 7 years ago

kculmback commented 7 years ago

This pull request specifically address issues #54 & #55

First, it reorganizes how plugins are loaded. They are added in the Gemfile rather than the _config.yml file. This allows bundler to handle the plugins and to serve them properly. It should also make it easier for people using github-pages to correctly add the plugin and have it manage which version of jekyll to use.

Secondly, it fixes a pagination issue brought up by @andycochran. Fixed by switching to the markup suggested by the jekyll website, here.

It also incorporates a suggestion by @andycochran to remove the a tags for the current pagination page. I also changed it so that the previous and next arrows are hidden on the last and first pages, respectively.

andycochran commented 7 years ago

😎 🎉