search

Foundation-for-Jekyll-sites / jekyll-foundation

Start your Jekyll (v3) project with Zurb Foundation for Sites (v6, sass).
MIT License
179 stars 64 forks source link

exclude yarn.lock #58

Closed jshwlkr closed 7 years ago

kculmback commented 7 years ago

Yarn actually suggests keeping the lockfile committed: https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/

core77 commented 7 years ago

You better keep the file, for Travis CI, too.

"If your Node.js project has the yarn.lock file in the repository root, we proceed to install Yarn and execute the yarn command instead of the default npm install."

jshwlkr commented 7 years ago

Maybe I should've been more verbose. Excluding via the config, not via gitignore. Should I be keeping that around in the _site folder?

core77 commented 7 years ago

I'm sorry. I missunderstood your intention.

The yarn.lock should be in the repo. But in _site we don't need it.

So it's good to exclude it in _config.yml.

kculmback commented 7 years ago

Sorry about my hasty comment! Should have looked at the actual files first, my bad!

core77 commented 7 years ago

@jshwlkr Good job. Thanks and merged!