search

FoundationDB / fdb-joshua

FoundationDB Correctness service
Apache License 2.0
28 stars 25 forks source link

Fix parameter for disabling ttl controller #43

Closed sfc-gh-bnutt closed 3 years ago

sfc-gh-bnutt commented 3 years ago

Upper case for all characters in ttl controller. Fix type for variable value

sfc-gh-bnutt commented 3 years ago

Apologies for the early merge. I will be sure to wait for approval next time.

xumengpanda commented 3 years ago

How did you test this change?

sfc-gh-bnutt commented 3 years ago

I had done a local execution of the script with dummy environment variables. Then it was tested in SF environnment. If it is causing issues, we can certainly revert it. The behavior does not change in that it will still default to the scaler performing the cleanup.

sfc-gh-kmakino commented 3 years ago

@xumengpanda We've tested this in Snowflake's environment. I apologize that I completely forgot to ask you to review it. This TTL stuff is guarded by a parameter, so it should be safe for you (... but we made a typo there, so it wasn't quite safe originally... 😅)

xumengpanda commented 3 years ago

@xumengpanda We've tested this in Snowflake's environment. I apologize that I completely forgot to ask you to review it. This TTL stuff is guarded by a parameter, so it should be safe for you (... but we made a typo there, so it wasn't quite safe originally... 😅)

Thanks for the context! I would let @ammolitor review it next time since he will suffer if the branch is broken. :)