search

FoundationDB / fdb-joshua

FoundationDB Correctness service
Apache License 2.0
28 stars 25 forks source link

add parameter to slow down new job creation #59

Closed ammolitor closed 3 years ago

ammolitor commented 3 years ago

This PR adds a parameter that will slow down the creation of new jobs in Kubernetes.

The current agent scaler will attempt to create as many new jobs as are calculated. This is great for rapid scale up, but triggers more than one EC2 API rate limit when running in EKS (related to NetworkInterfaces). In an effort to avoid the API rate limits, this new parameter will compare new_jobs to a max_new_jobs and only create the lesser number of jobs for each pass in the loop.

The default for max_new_jobs is the same as the default for max_jobs so, under a default deployment, this new logic should have no functional impact.

sfc-gh-kmakino commented 3 years ago

LGTM

Please see my comment above too. 🙂 This has a behavior change to existing Joshua clusters.