search

FoundationDB / fdb-joshua

FoundationDB Correctness service
Apache License 2.0
28 stars 25 forks source link

Use curl --retry for downloading old binaries #70

Closed sfc-gh-anoyes closed 2 years ago

sfc-gh-anoyes commented 2 years ago

Otherwise if the server responds with e.g. a 503 error code, the image ends up with an old binary that is not actually a binary.

ammolitor commented 2 years ago

I don't have any opposition to --retry but should we use --fail as well (or instead)? If the goal is to avoid an html file masquerading as a binary it might be good to fail.

sfc-gh-anoyes commented 2 years ago

I don't have any opposition to --retry but should we use --fail as well (or instead)? If the goal is to avoid an html file masquerading as a binary it might be good to fail.

Done