FoundationDB / fdb-kubernetes-operator

A kubernetes operator for FoundationDB

Apache License 2.0

241 stars 82 forks source link

Make sure we skip the automatic replacements if the cluster is unavailable #2054

Closed johscheuer closed 3 months ago

johscheuer commented 4 months ago

Description

If the cluster is not available we shouldn't perform automatic replacements as the operator is not able to make any good decision. The operator will not replace more than MaxConcurrentReplacements in the worst case, but I still think it's better to skip this feature at all if the cluster is unavailable.

Type of change

Please select one of the options below.

Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

CI will run e2e tests.

Documentation

Follow-up

foundationdb-ci commented 4 months ago

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

Commit ID: 4eaa012a308dc88302e431eb2a158c9ac0b26706
Duration 2:44:28
Result: :x: FAILED
Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 4 months ago

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

Commit ID: 99b3c5cd818f85bc0ba0b982d0119b1a7ad889ea
Duration 2:46:53
Result: :x: FAILED
Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

nicmorales9 commented 3 months ago

Looks good with requeue as well 👍

foundationdb-ci commented 3 months ago

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

Commit ID: cd5c66bd35579b0f2bc81e9c95b11c83ad05f801
Duration 2:57:44
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)