FoundationDB / fdb-kubernetes-operator

A kubernetes operator for FoundationDB
Apache License 2.0
241 stars 82 forks source link

Set log dir and log group through environment variables for unified image #2060

Closed nicmorales9 closed 3 months ago

nicmorales9 commented 3 months ago

Description

fixes https://github.com/FoundationDB/fdb-kubernetes-operator/issues/245

Type of change

Discussion

N/A

Testing

Unit tests, spun up e2e tests and checked that the logs are sent to the directory specified by the env variable, and that they all included the expected log group (cluster.spec.logGroup) incl. the logs from fdbcli

Do we need to perform additional testing once this is merged, or perform in a larger testing environment? Don't think so, no

Documentation

I don't think documentation change is needed, I think the issue is that there is nothing passively allowing logging to work and that this shouldn't be intrusive. Do let me know if that sounds wrong!

Follow-up

N/A

foundationdb-ci commented 3 months ago

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

foundationdb-ci commented 3 months ago

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

foundationdb-ci commented 3 months ago

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

nicmorales9 commented 3 months ago

hmm, the test failure looks unrelated:

• [FAILED] [2699.779 seconds]
Operator Upgrades with chaos-mesh with a partitioned pod which eventually gets replaced [It] Upgrade from 7.1.57 to 7.3.33 [e2e, pr]
/codebuild/output/src1695824796/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/upgrade_test_configuration.go:115

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc00044bb10>: 
      pod pr-911-lb2hrqt3/fdb-cluster-ulu39f6e-storage-5 was not removed in the expected time
      {
          s: "pod pr-911-lb2hrqt3/fdb-cluster-ulu39f6e-storage-5 was not removed in the expected time",
      }
  occurred
  In [It] at: /codebuild/output/src1695824796/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_upgrades_with_chaos/operator_upgrades_with_chaos_test.go:188 @ 06/13/24 16:36:42.964
------------------------------

going to try rerunning

foundationdb-ci commented 3 months ago

Result of fdb-kubernetes-operator-pr on Linux CentOS 7