FoundationDB / fdb-kubernetes-operator

A kubernetes operator for FoundationDB

Apache License 2.0

241 stars 82 forks source link

Add support for isolating a process group in the operator #2068

Closed johscheuer closed 3 months ago

johscheuer commented 3 months ago

Description

Fixes: https://github.com/FoundationDB/fdb-kubernetes-operator/issues/1906

Operator support for https://github.com/apple/foundationdb/pull/11464.

Type of change

Please select one of the options below.

New feature (non-breaking change which adds functionality)

Discussion

Testing

Added a new e2e test for that and ran it manually:

ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report
autogenerated by Ginkgo
[ReportAfterSuite] PASSED [0.003 seconds]
------------------------------

Ran 1 of 54 Specs in 424.461 seconds
SUCCESS! -- 1 Passed | 0 Failed | 10 Pending | 43 Skipped
PASS | FOCUSED
FAIL    github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator       424.992s
FAIL

Documentation

Added the documentation for this new feature.

Follow-up

foundationdb-ci commented 3 months ago

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

Commit ID: 871a07ef700d6cceda66c7cba4a0a93c04e3fbf1
Duration 2:53:00
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 3 months ago

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

Commit ID: e2943cf94111e6018104bae78e7e50ea22b0d261
Duration 2:50:28
Result: :x: FAILED
Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

johscheuer commented 3 months ago

Test failure was:

• [FAILED] [433.262 seconds]
Operator when a Pod is unscheduled and another Pod is being replaced [It] should remove the targeted Pod [e2e, pr]
/codebuild/output/src503310604/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:584

  [FAILED] Timed out after 300.001s.
  Expected
      <bool>: false
  to be true
  In [It] at: /codebuild/output/src503310604/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/fdb_cluster.go:1222 @ 06/24/24 17:14:25.628
------------------------------

The failure is unrelated and probably needs an increase in the timeout.