FoundationDB / fdb-kubernetes-operator

A kubernetes operator for FoundationDB

Apache License 2.0

241 stars 82 forks source link

Don't reset the last reconciled generation #2073

Closed johscheuer closed 3 months ago

johscheuer commented 3 months ago

Description

Fixes: https://github.com/FoundationDB/fdb-kubernetes-operator/issues/873

Type of change

Please select one of the options below.

New feature (non-breaking change which adds functionality)

Discussion

Before that we would reset the generation to 0 which can be confusing in many cases when the reconciliation drops from a precious number to 0.

Testing

Ran unit tests and an e2e test suite.

Documentation

Not needed.

Follow-up

foundationdb-ci commented 3 months ago

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

Commit ID: a93d80df677dba469e6d33abcba7b52fa6cfa408
Duration 2:32:53
Result: :x: FAILED
Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 3 months ago

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

Commit ID: a93d80df677dba469e6d33abcba7b52fa6cfa408
Duration 2:37:25
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

johscheuer commented 3 months ago

Changes look good to me though it feels like it should not close the linked issue as it does not add the observedGenerations nor Conditions. If this is intentional, an explanation on the issue would be good

For the conditions we have a dedicated issue: https://github.com/FoundationDB/fdb-kubernetes-operator/issues/1000. Adding the observedGeneration didn't seem to bring a huge value in this context.