Remove enable node watch setting as this can be enabled with an env variable

[johscheuer]

Description

I added a bit prematurely the new setting but the setting is actually not needed, so we should remove it. This will be a breaking change but since the feature is only relevant for the unified image, which is not yet released, I think it's okay to remove it.

Type of change

Please select one of the options below.

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Discussion

Are there any design details that you would like to discuss further?

Testing

Manual run:

 2024/06/24 14:51:24 waiting until the cluster jscheuermann/jdev is healthy and reconciled
  2024/06/24 14:51:25 reconciled name=jdev, namespace=jscheuermann, generation:4
• [120.171 seconds]
------------------------------
[AfterSuite]
/Users/jscheuermann/go/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:98
[AfterSuite] PASSED [0.000 seconds]
------------------------------
[ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report
autogenerated by Ginkgo
[ReportAfterSuite] PASSED [0.004 seconds]
------------------------------

Ran 1 of 53 Specs in 356.735 seconds
SUCCESS! -- 1 Passed | 0 Failed | 9 Pending | 43 Skipped
PASS | FOCUSED
FAIL    github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator       357.160s
FAIL

Documentation

Updated.

Follow-up

-

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: b74ab16f2c4b88fadbfce582596dab6b4836dcb1
• Duration 3:06:48
• Result: :x: FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 0c5546f82b868414cfa9aa3435165cffcb4c93da
• Duration 2:57:06
• Result: :x: FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[johscheuer]

• [FAILED] [393.668 seconds]
Operator when a Pod is unscheduled and another Pod is being replaced [It] should remove the targeted Pod [e2e, pr]
/codebuild/output/src2290440694/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:583

  [FAILED] Timed out after 300.001s.
  Expected
      <bool>: false
  to be true
  In [It] at: /codebuild/output/src2290440694/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/fdb_cluster.go:1222 @ 06/24/24 17:08:19.249
------------------------------

Same failure as in the other test.