Closed alecgrieser closed 2 years ago
Does that error indicate that commitVersion - 101_000_000
was negative?
That does seem like a fairly plausible explanation.... The clearest place in the FDB codebase that I could find version_invalid
being thrown was in a check to make sure the version passed to setVersion
is non-negative:
I posted a PR that changes the test to check if the version is in the right range (and skips the test if it's not): #1434. That being said, it's possible a more nuanced solution that tries to mock some more things and inject an error would be better, though it's a bit difficult to insert that mocking logic into the test as it's currently implemented. But this would at least stop the test from causing builds to fail.
This has happened in I think two PRBs now, one for #1399 and one for #1373. In those cases, the
SizeStatisticsCollectorTest
has failed with a "version not valid" error and the following stack trace:This appears to happen intermittently, so it will take some investigation to figure out what's going on here