Add more complete direction control to LogicalSortExpression.

FoundationDB / fdb-record-layer

A record-oriented store built on FoundationDB

Apache License 2.0

570 stars 102 forks source link

Add more complete direction control to LogicalSortExpression. #2796

Closed MMcM closed 1 week ago

MMcM commented 2 weeks ago

Extends #2748 and #2771.

foundationdb-ci commented 2 weeks ago

Result of fdb-record-layer-pr on Linux CentOS 7

Commit ID: 3d85d76e139e25eaec5dc9b8a7a1bd2dc9d59378
Duration 0:46:59
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of fdb-record-layer-pr on Linux CentOS 7

Commit ID: f45ea09cb2569fcbb662fe4dbdb68cba21f16bd5
Duration 0:47:08
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 2 weeks ago

Result of fdb-record-layer-pr on Linux CentOS 7

Commit ID: bca6aa259308b94919610ea9966f49bd49a0d266
Duration 0:45:52
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 week ago

Result of fdb-record-layer-pr on Linux CentOS 7

Commit ID: 8523f0bb52c79afc4cf3a5057ad776b3a547237f
Duration 0:46:21
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 week ago

Result of fdb-record-layer-pr on Linux CentOS 7

Commit ID: fc9b5266e3f9422952a8f2c10698edcb733b6a3b
Duration 0:46:40
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

normen662 commented 1 week ago

Can you check that the right compatibilities are enforced (as well as the wrong ones don't match) in Ordering.combineBindingsForIntersection() and Ordering.combineBindingsForUnion()?

foundationdb-ci commented 1 week ago

Result of fdb-record-layer-pr on Linux CentOS 7

Commit ID: f79595eb56d5bb3c62bf99c5358719f322298f4e
Duration 0:44:47
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

MMcM commented 1 week ago

Can you check that the right compatibilities are enforced (as well as the wrong ones don't match) in Ordering.combineBindingsForIntersection() and Ordering.combineBindingsForUnion()?

I believe that the new counterflow nulls enum members are still isDirectional, so that

        if (leftSortOrder.isDirectional() && rightSortOrder.isDirectional()) {
            if (leftSortOrder != rightSortOrder) {

takes the conservative approach. Also the directional + FIXED cases, where it takes the non-fixed side, seem still correct.

foundationdb-ci commented 1 week ago

Result of fdb-record-layer-pr on Linux CentOS 7

Commit ID: 087cd830c2b654e69671e6218f364823b49969c6
Duration 0:43:59
Result: :x: FAILED
Error: Error while executing command: ./gradlew --no-daemon --console=plain -b ./build.gradle build destructiveTest -PcoreNotStrict -PreleaseBuild=false -PpublishBuild=false -PspotbugsEnableHtmlReport. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci commented 1 week ago

Result of fdb-record-layer-pr on Linux CentOS 7

Commit ID: 97da97773e00b503a7945104cc710f1d7a3eb2f4
Duration 0:45:54
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)