FoundationDB / fdb-record-layer

A record-oriented store built on FoundationDB
Apache License 2.0
570 stars 102 forks source link

add Support for nested `DynamicMessage` in `ConstantObjectValue` #2806

Closed g31pranjal closed 5 days ago

g31pranjal commented 1 week ago

The ConstantObjectValue has a very naive support to deal with DynamicMessage wherein the object is not checked if there is a need for promotions. However, this fails if the object is an array of DynamicMessage.

We need a to have a way to support arbitrary nesting of DynamicMessage but not generally support promotions in them. For instance, we can check if the shape of DynamicMessage is identical and fail if not without even trying to calculate promotions.