search

FoundationDB / fdb-record-layer

A record-oriented store built on FoundationDB
Apache License 2.0
575 stars 102 forks source link

Remove "store" parameter from Comparisons.Comparison.evaluate #791

Open alecgrieser opened 4 years ago

alecgrieser commented 4 years ago

It appears that we are keeping around an FDBRecordStore parameter in Comparisons.Comparison. I think this stems from a period of time when that was necessary to evaluate parameters, but it appears that they are all unused now (from what I can tell). We should, as much as possible, deprecate those old methods and remove the parameter.

alecgrieser commented 4 years ago

This method in question: https://github.com/FoundationDB/fdb-record-layer/blob/592151d7466a8252e6d8e03252746be6fc68710a/fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/query/expressions/Comparisons.java#L636