FoundationGames / EnhancedBlockEntities

A Minecraft Mod for Fabric which aims to make Block Entity rendering faster and more customizable with almost no compromises.
GNU Lesser General Public License v3.0
230 stars 52 forks source link

Signs not rendering with Enhanced Signs enabled #107

Open ghost opened 1 year ago

ghost commented 1 year ago

Initially, I thought this was a texture issue, however after switching to Optifine from Sodium, signs work normally, which led me to testing EBE. Using BetterVanillaBuilding 2.75, Signs render as invisible with Text showing in air when using Enhanced Signs.

Screenshot with Enhanced Signs enabled: 2022-07-12_09 58 06

Screenshot 2 with Enhanced Signs disabled: 2022-07-12_09 58 53

Log file from Latest run of Minecraft: latest.log

Shader pack is outdated, but also disabled which shouldn't interact, as stated this issue only occurs when using Enhanced Signs.

Minecraft Version: 1.19 Fabric Loader: 0.14.8 Modlist: Architectury Api Animatica AutoFish Better F3 CIT Resewn Cloth Config API Colormatic Connectivity Continuity CraftPresence Cull Leaves CEM (Custom Entity Models) Dynamic FPS Enhanced Block Entities Entity Culling Entity Texture Features Fabric Language Kotlin Indium InventoryHud+ Iris Jade LambdaBetterGrass LambDynamicLights LazyDFU Lithium Mod Menu Mouse Tweaks Mod Menu No Chat Reports NoFog Reeses Sodium Options Shulker Tooltip Sodium Sodium Extra Starlight Xaeros Minimap Xaeros Worldmap Zoomify

FoundationGames commented 1 year ago

Try without your resource pack, and if that works, it's likely an issue with the resource pack

ghost commented 1 year ago

Try without your resource pack, and if that works, it's likely an issue with the resource pack

Resource pack works absolutely fine when used with Optifine, it’s BetterVanillaBuilding. I physically had to disable EBE via Curseforge to figure out it was linked into here, from there changed settings via ModMenu to link with enhanced signs.

EDIT: it also works fine when I remove EBE, even with Sodium.

FoundationGames commented 1 year ago

Resource pack works absolutely fine when used with Optifine

That's because Optifine doesn't have EBE in it - some resource packs break EBE and make things invisible and I'd like to know if yours is doing that too

ghost commented 1 year ago

Resource pack works absolutely fine when used with Optifine

That's because Optifine doesn't have EBE in it - some resource packs break EBE and make things invisible and I'd like to know if yours is doing that too

Alright, then let me answer that question another way. I didn’t have this issue on 1.18.2 Sodium with EBE, I’ve clean updated to 1.19, before updating everything worked fine, post update EBE breaks signs. However, to answer the question in your way, I also used StayTrue for 1.19 with the same issue.

edit: works with default, but it’s been working for weeks before now, which is why I opened an issue

FoundationGames commented 1 year ago

I'll have to look into the resource pack later, for now just check to make sure that the packs are ordered correctly (vanilla below additional packs), and if nothing else works, keep Enhanced Signs turned off.

SandWoodJones commented 1 year ago

I'm getting a similar error with enhanced signs. Although signs display correctly in the world the edit sign screen looks like this: image This only happens with modded signs,

FlooferLand commented 1 year ago

I'm having the same issue and it's really hard to find out what exactly is breaking it. For me, deleting the sign blockstates in my resource pack fixed it