search

FoundationGames / EnhancedBlockEntities

A Minecraft Mod for Fabric which aims to make Block Entity rendering faster and more customizable with almost no compromises.
GNU Lesser General Public License v3.0
233 stars 57 forks source link

[Minecraft 1.19.3] Invisible chests, signs, shulker boxes, beds and bell with QFAPI 5.0.0-beta.8+0.75.1 and QSL 4.0.0-beta.12 #136

Closed YukiAyase closed 1 year ago

YukiAyase commented 1 year ago

Chests (normal, trapped and ender chests), signs (both normal and hanging), beds, shulker boxes, and bells, seems to be invisible and has missing textures when interacted, it only happens with QFAPI 5.0.0-beta.8+0.75.1 and QSL 4.0.0-beta.12
Properly works with Fabric API and any QFAPI versions lower than what is mentioned It may be related to the latest change they've made with flattening resource packs in QSL 4.0.0-beta.12
https://github.com/QuiltMC/quilt-standard-libraries/pull/270
Latest Fabric API 2023-03-05_10 48 50

2023-03-05_10 49 30
QFAPI 5.0.0-beta.8+0.75.1 and QSL 4.0.0-beta.12 2023-03-05_10 59 10 2023-03-05_10 53 02 2023-03-05_10 53 04 2023-03-05_10 53 19

FoundationGames commented 1 year ago

Do you see any errors in your game log? If so, that might be EBE's code breaking against QSL's group resource pack flattening, and might explain why no resources seem to load

YukiAyase commented 1 year ago

Do you see any errors in your game log? If so, that might be EBE's code breaking against QSL's group resource pack flattening, and might explain why no resources seem to load

From lines 490 to 553 I think are the relevant errors https://mclo.gs/5BRZqUV

Edit: There're no other errors except for that

FoundationGames commented 1 year ago

The issue has been found, QSL's resource pack flattening replaces a critical piece of code that EBE uses (potential solutions may be explored)

YukiAyase commented 1 year ago

This issue is now fixed! Quilt has released an update for QSL [1.19.3] QFAPI 5.0.0-beta.9 and QSL 4.0.0-beta.13

NattoRiisa commented 1 year ago

i feel like a fix should be done for the mod itself too, as stated by LambdAurora

Though, in the process of debugging I found out an issue in EBE itself, INVOKE_ASSIGN makes it so the injected pack is not present in the packs field of the class, using INVOKE instead should fix it. This is very important because QSL may recompute namespaces and it could lead to the pack being voided.

FoundationGames commented 1 year ago

i feel like a fix should be done for the mod itself too, as stated by LambdAurora

Though, in the process of debugging I found out an issue in EBE itself, INVOKE_ASSIGN makes it so the injected pack is not present in the packs field of the class, using INVOKE instead should fix it. This is very important because QSL may recompute namespaces and it could lead to the pack being voided.

Fixed in 0.8.1+