search

FoundationGames / EnhancedBlockEntities

A Minecraft Mod for Fabric which aims to make Block Entity rendering faster and more customizable with almost no compromises.
GNU Lesser General Public License v3.0
229 stars 52 forks source link

1.19.4 #146

Closed MeeniMc closed 1 year ago

MeeniMc commented 1 year ago

Update to 1.19.4

fixes: #144

tajemniktv commented 1 year ago

Hey, any chance for a prebuilt .jar? 🥲

MeeniMc commented 1 year ago

The main author is still active I'll let them publish after they can review.

MeeniMc commented 1 year ago

Some mixins are not mapped correctly atm.

MeeniMc commented 1 year ago

I fixed the mixin problems ready for review

HhiPyrene commented 1 year ago

Broken when using LambdaBetterGrass. latest.log

YukiAyase commented 1 year ago

Broken when using LambdaBetterGrass. latest.log

This incompatibility is caused by EBE It needs to be fixed on EBE's side Its present in 1.19.3

Though, in the process of debugging I found out an issue in EBE itself, INVOKE_ASSIGN makes it so the injected pack is not present in the packs field of the class, using INVOKE instead should fix it. This is very important because QSL may recompute namespaces and it could lead to the pack being voided.

-LambdAurora

Maybe consider adding this fix to the PR? Though, doing so will cause block breaking particles to have missing textures when you have experimental feature ON for beds, chests and signs while having LBG installed

FoundationGames commented 1 year ago

I would rather fix this in the 1.19.3 branch (and not have the author of this PR worry about it), it would make things more straightforward when merging

MeeniMc commented 1 year ago

tech preview build available. https://github.com/MeeniMc/EnhancedBlockEntities/releases/tag/v0.8.rc.1%2B1.19.4

ElBananaa commented 1 year ago

tech preview build available. https://github.com/MeeniMc/EnhancedBlockEntities/releases/tag/v0.8.rc.1%2B1.19.4

Hey, thanks for the 1.19.4 version above, however, it appears to be broken for me, chests, signs, shulker boxes and beds all appear fully invisible (with and without resource pack).

Here's my entire mod list (just in case). I am using Quilt (Loader v0.18.10).

Any idea on how to fix this? Thanks! :)

YukiAyase commented 1 year ago

Hey, thanks for the 1.19.4 version above, however, it appears to be broken for me, chests, signs, shulker boxes and beds all appear fully invisible (with and without resource pack).

Here's my entire mod list (just in case). I am using Quilt (Loader v0.18.10).

Any idea on how to fix this? Thanks! :)

Since you're on Quilt, I am assuming you're using LambdaBetterGrass along side EBE There is currently an incompatibility with EBE and LBG that causes this, either removing LBG or EBE is the only current solution

ElBananaa commented 1 year ago

Hey, thanks for the 1.19.4 version above, however, it appears to be broken for me, chests, signs, shulker boxes and beds all appear fully invisible (with and without resource pack). Here's my entire mod list (just in case). I am using Quilt (Loader v0.18.10). Any idea on how to fix this? Thanks! :)

Since you're on Quilt, I am assuming you're using LambdaBetterGrass along side EBE There is currently an incompatibility with EBE and LBG that causes this, either removing LBG or EBE is the only current solution

I tried without LBG it still didn't work for a reason I ignore. Do you have any other ideas?

MeeniMc commented 1 year ago

Are you using Quilt loader? Please provide a log.

adilrepas commented 1 year ago

tech preview build available. https://github.com/MeeniMc/EnhancedBlockEntities/releases/tag/v0.8.rc.1%2B1.19.4

it works very well

FunkyNico commented 1 year ago

I have tested the build and for some reason has a problem with DashLoader mod (i also tested the 1.20.1 build from here with the same mod and didn't have the same issue.)

Logs: Here

Thanks.

FoundationGames commented 1 year ago

Will merge, thanks for contributing! The actual 1.19.4 update may take a while longer, since decorated pots need to be optimized