FoundationGames / EnhancedBlockEntities

A Minecraft Mod for Fabric which aims to make Block Entity rendering faster and more customizable with almost no compromises.
GNU Lesser General Public License v3.0
229 stars 52 forks source link

1.20.1 #151

Closed Brokkonaut closed 1 year ago

Brokkonaut commented 1 year ago

Update to 1.20.1

TheRealJake12 commented 1 year ago

upload an actions build here we need something for now

TheRealJake12 commented 1 year ago

upload an actions build here we need something for now

Brokkonaut commented 1 year ago

upload an actions build here we need something for now

Just clone the repo and use ./gradlew build

TheRealJake12 commented 1 year ago

upload an actions build here we need something for now

Just clone the repo and use ./gradlew build

I'm not a java programmer but alr, I'll try

duplexsystem commented 1 year ago

I get missing texture particles when breaking a cherry sign

Brokkonaut commented 1 year ago

I get missing texture particles when breaking a cherry sign

should be fixed now

Rektroth commented 1 year ago

Should the Gradle wrapper be updated to 8.1.1? I get this error otherwise:

* What went wrong:
Could not open cp_settings generic class cache for settings file 'C:\Users\Rektroth\source\repos\EnhancedBlockEntities\settings.gradle' (C:\Users\Rektroth\.gradle\caches\8.0\scripts\9i8ii8b4tcz62c0ak7z8aquwy).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 64

Not sure why. I'm using Java 17, but it acts like I'm using 20.

Guerdi commented 1 year ago

unfortunately incompatible with LambdaBetterGrass, block entities become invisible

ImGRUI commented 1 year ago

unfortunately incompatible with LambdaBetterGrass, block entities become invisible

Not fork issue (https://github.com/LambdAurora/LambdaBetterGrass/issues/83), but You can fix that by changing 27 line in src\main\java\foundationgames\enhancedblockentities\mixin\LifecycledResourceManagerImplMixin.java, replace "INVOKE_ASSIGN" to "INVOKE" ( just saw pull request https://github.com/FoundationGames/EnhancedBlockEntities/pull/147 with this and LambdAurora mentioned this fix in the LambdaBetterGrass issue) If it doesn't work, change experimental features to another value. Works for me

Guerdi commented 1 year ago

I hadn't updated my modpack since 1.19 so I missed this problem, thank you very much for the quick response! Unfortunately, now the problem is that the block destruction particles are missing (black and purple). It's still less disturbing than before, I guess...

ImGRUI commented 1 year ago

I hadn't updated my modpack since 1.19 so I missed this problem, thank you very much for the quick response! Unfortunately, now the problem is that the block destruction particles are missing (black and purple). It's still less disturbing than before, I guess...

Hmm, i don't have that problem. Turn off Experimental Features, maybe it help.

TheRealJake12 commented 1 year ago

Update looks good, will merge eventually Some accessor methods in SignBlockEntityRenderAccessor appear to be commented out, if there's a reason for it please let me know; if not, I would prefer them removed.

The final update to 1.20 may take some time even after merging this, since EBE will need to include block models and technical changes for the new decorated pots, which also use entity rendering.

oh my god he's awake

TiboOpGithub commented 1 year ago

Is there a safe version we can already use?