search

FoundationGames / EnhancedBlockEntities

A Minecraft Mod for Fabric which aims to make Block Entity rendering faster and more customizable with almost no compromises.
GNU Lesser General Public License v3.0
230 stars 52 forks source link

Delete unnecessary faces from models, add cullface where it makes sense #82

Closed muzikbike closed 2 months ago

muzikbike commented 2 years ago

These shouldn't cause any visual differences outside of Spectator or otherwise clipping into blocks in unexpected ways, but cuts down on model file size a bit. The game also doesn't need to render as much, which is also a bonus.

Fixes #77, fixes #78 (for the former, cullface was left out for sign tops since it'd look weird with carpets on top, as well as several faces which the game refuses to cull since the block's hitbox doesn't extend out far enough, such as the thin sides of standing signs as well as chest locks)

RaptaG commented 12 months ago

This has been implemented in the latest version

muzikbike commented 2 months ago

why wasn't this merged in then? it was open for well over a year