search

FoundationGames / Sandwichable

Customizable Sandwich mod for Minecraft
MIT License
32 stars 28 forks source link

[Game CRASH] Any interaction with a Sandwich kicks players from the server #102

Open Snoe0 opened 3 years ago

Snoe0 commented 3 years ago

Description Whenever someone interacts at all with a sandwich, someone on the server gets disconnected (not necessarily the one doing it).

Steps to Reproduce Make a sandwich (this might cause it), put it into a chest, break the chest.

Crash Log image

https://paste.ee/p/haFnz

Media If you can, post some media (video, gif, link) to further clarify the issue and what causes the crash. image

Snoe0 commented 3 years ago

This also happens sometimes if you even hold the sandwich.

FoundationGames commented 3 years ago

Replay Mod had a stroke it seems I don't know how fixable this is but I'll leave the issue open Please try again without replay mod and see if the issue reoccurs, Sandwichable barely touches OpenGL itself at all and your crash is a GL error with Replay Mod prominently being in the stacktrace

Snoe0 commented 3 years ago

But it crashes other people, yet they don't have replay mod.

Snoe0 commented 3 years ago

Should I write down a list of all the mods I have? There might be a mod that everyone has that is causing the crash.

I also forced them to be stackable, which could be causing the issue.

Someone else also seemed to have a similar issue, but it occurred when people ate the sandwich, and for me it is if it is even held.

Snoe0 commented 3 years ago

Update I just tested it and forcing them to stack caused the issue.

I used the Allstackable mod in case you need it.

Snoe0 commented 3 years ago

It is continuing to happen and we are unsure why.

Snoe0 commented 3 years ago

Right Before the Crash image

When Rejoining image

Snoe0 commented 3 years ago

I am like 70% sure it is this mod, but it could be something else as well.

triphora commented 3 years ago

You should probably get Not Enough Crashes and Mixin Trace.

Snoe0 commented 3 years ago

Here is the crash error with those mods installed.

image (Same thing)

triphora commented 3 years ago

Those two mods only take effect upon an actual crash report iirc. As Foundation said:

sandwichable doesn’t touch any gl stuff

FoundationGames commented 3 years ago

Please post a crash log with those mods installed, it's recommended to not ever post screenshots of logs, but rather post them on paste websites. Sandwichable hardly touches gl code at all, and your issue is a GL error. The unused recipe category warning does not mean anything. This is more than likely caused by another mod such as minimap that touches a lot of render code in an unsafe way.

Snoe0 commented 3 years ago

It disconnects people but doesn't crash games so I don't get a crash report. Server side the error is java.util.ConcurrentModificationException

I guess I will just do some more testing, it seems like the disconnect is not from Sandwichable currently. Earlier today, people could just lock the server by spamming back and forth with Sandwiches.

FoundationGames commented 3 years ago

Please just post your game logs then, on a paste site. Also try to reproduce this issue with only Sandwichable and Fabric API installed.