search

FoundationGames / Sandwichable

Customizable Sandwich mod for Minecraft
MIT License
32 stars 28 forks source link

Create fr_fr.json #106

Open Water-Kitten opened 3 years ago

Water-Kitten commented 3 years ago

French translation for Sandwichable on 1.17

As I did for the previous version, I made a new french translation for the 1.17 version.

I hope it'll work great, I never did any "pull request" before and there's not a lot of explications/tutorials in french about it. Sorry if I did it wrong ! Just tell me and I'll correct it right.

Hope it will help you !

Water-Kitten commented 3 years ago

Like this? I've use the en_us.json for the first one too, I don't where it found those last line.

I remove them manualy on the file. Would it have done the same thing if I had clicked on "Add suggestion to batch" or it is for something else?

Thank you for your help and your correction !

EcoBuilder13 commented 3 years ago

Yes, that fixes it. The "Add suggestion to batch" would of done the same thing for the most part. It's used so you can put all of the requested changes you accept into the same commit automatically and it adds the people who suggested the change as co-authors. I think you got those lines because you copied the file from a browser tab and it highlighted the bottom row of the webpage so it got copied.

Water-Kitten commented 3 years ago

Ow sorry, your name will not be add as co-author 'cause I changed it manualy...

Thanks again for your help and explanations, realy appreciate it!

FoundationGames commented 3 years ago

Hello, the 1.17 branch is not actually updated to 1.17 - it is equivalent to the indev branch. Therefore when I update the mod to 1.17, this translation might need to be updated. Sorry for the misleading branch titles, I hope I can hear back. There is no ETA on when 1.17 will be completed, but it has not started thus far.

Water-Kitten commented 3 years ago

Okay, I'll try to pass this one on "indev" so you'll can have the current translation up-to-date anyway ! Don't hesitate to notice me when any updates or changes are needed !

Sorry to have bothered the pulls with all my translations' pull request...