[Gameplay Bug] Overhanging salt lake; may be Overworld Two issue

saltyseadoggo commented 3 years ago

Description I found this salt lake at around -60, 75, 900 in a world generated with Overworld Two and Terrestria and seed -6418084019852448064. It is largely floating in the air, and also jutting into the hillside on one side.

2021-01-10_12 26 01 2021-01-10_12 32 06 2021-01-10_12 32 11

How To Reproduce

Add the latest versions of Sandwichable, Overworld Two and Terrestria to your mods folder.
Start Minecraft, and generate a world with the Overworld Two world type (click through the world type options in more options) and seed -6418084019852448064. Due to the way in which Overworld Two works, this seed will generate an entirely different world in the default world type.
Run /teleport -60 75 900 and inspect the salt lake.

Expected Behavior I would expect salt lakes to not generate mostly floating in the air, nor with floating trees above them. However, I understand if this is an anomaly characteristic of Minecraft world generation, as vanilla Minecraft structures such as villages occasionally have similar issues. I also can't be sure if this occurs without Overworld Two due to salt lakes being inconsistent to find.

Media See above, if you haven't already.

saltyseadoggo commented 3 years ago

I've found another similarly overhanging lake, this one underwater, at position 980, 62, 640 in a world generated with the same mods and seed -514875818933665995. This one also has strange lighting.

2021-01-10_12 56 10 2021-01-10_12 56 14

FoundationGames commented 3 years ago

Salt lakes are known to generate partially hovering, which is why I made the undersides have a curved shape. That can be considered intended behavior. However, I never considered the possibility of them generating in the below-sea-level-lakes in forests, so this will be fixed. Thanks for the feedback!

FoundationGames commented 3 years ago

And as for the floating trees, this is an issue with vanilla "pond" features as well, and has to do with the order chunks generate in. Salt pools are meant to generate before trees and grass, however the next chunk may generate a salt pool sticking out into an old chunk, which contains already generated trees. There is no clean fix for this.

saltyseadoggo commented 3 years ago

You're welcome! Thank you for the technical explanation as to why this happens! I find this stuff interesting~

FoundationGames / Sandwichable

[Gameplay Bug] Overhanging salt lake; may be Overworld Two issue #70